From: Bart Van Assche <bvanassche@acm.org>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>,
Mike Christie <michaelc@cs.wisc.edu>, Tejun Heo <tj@kernel.org>,
Chanho Min <chanho.min@lge.com>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v7 3/9] Introduce scsi_device_being_removed()
Date: Fri, 07 Dec 2012 10:11:55 +0100 [thread overview]
Message-ID: <50C1B2DB.9070001@acm.org> (raw)
In-Reply-To: <e6b81317b8ba62b6493cf67645cb1501@sf-mail.de>
On 12/07/12 09:40, Rolf Eike Beer wrote:
>> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
>> index 55367b0..767dd16 100644
>> --- a/include/scsi/scsi_device.h
>> +++ b/include/scsi/scsi_device.h
>> @@ -442,6 +442,11 @@ static inline int scsi_device_created(struct
>> scsi_device *sdev)
>> return sdev->sdev_state == SDEV_CREATED ||
>> sdev->sdev_state == SDEV_CREATED_BLOCK;
>> }
>> +static inline int scsi_device_being_removed(struct scsi_device *sdev)
>> +{
>> + return sdev->sdev_state == SDEV_CANCEL ||
>> + sdev->sdev_state == SDEV_DEL;
>> +}
>>
>> /* accessor functions for the SCSI parameters */
>> static inline int scsi_device_sync(struct scsi_device *sdev)
>
> Newline missing before the new function.
Hello Rolf,
Well spotted. Did you realize I had left out the newline on purpose, to
preserve consistency with the rest of the header file ?
Thanks,
Bart.
next prev parent reply other threads:[~2012-12-07 9:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 15:51 [PATCH v7 0/9] More device removal fixes Bart Van Assche
2012-12-06 15:52 ` [PATCH v7 1/9] Fix race between starved list processing and device removal Bart Van Assche
[not found] ` <034101cdee08$2d67f870$8837e950$@min@lge.com>
2013-02-09 15:06 ` Bart Van Assche
2012-12-06 15:53 ` [PATCH v7 2/9] Remove get_device() / put_device() pair from scsi_request_fn() Bart Van Assche
2012-12-06 15:55 ` [PATCH v7 3/9] Introduce scsi_device_being_removed() Bart Van Assche
2012-12-07 6:48 ` Hannes Reinecke
2012-12-07 8:40 ` Rolf Eike Beer
2012-12-07 9:11 ` Bart Van Assche [this message]
2012-12-07 10:02 ` Rolf Eike Beer
2012-12-07 12:43 ` Bart Van Assche
2012-12-07 13:41 ` Rolf Eike Beer
2012-12-06 15:55 ` [PATCH v7 4/9] Remove offline devices when removing a host Bart Van Assche
2012-12-07 15:10 ` Hannes Reinecke
2012-12-07 15:33 ` Bart Van Assche
2012-12-07 17:21 ` Bart Van Assche
2012-12-06 15:56 ` [PATCH v7 5/9] Disallow changing the device state via sysfs into "deleted" Bart Van Assche
2012-12-07 6:55 ` Hannes Reinecke
2012-12-07 12:46 ` Bart Van Assche
2012-12-07 13:33 ` Bart Van Assche
2012-12-07 13:36 ` Hannes Reinecke
2012-12-06 15:57 ` [PATCH v7 6/9] Avoid saving/restoring interrupt state inside scsi_remove_host() Bart Van Assche
2012-12-07 6:55 ` Hannes Reinecke
2012-12-06 15:58 ` [PATCH v7 7/9] Make scsi_remove_host() wait for device removal Bart Van Assche
2012-12-06 15:59 ` [PATCH v7 8/9] Make scsi_remove_host() wait until error handling finished Bart Van Assche
2012-12-07 6:58 ` Hannes Reinecke
2012-12-06 16:00 ` [PATCH v7 9/9] Avoid that scsi_device_set_state() triggers a race Bart Van Assche
2012-12-07 6:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C1B2DB.9070001@acm.org \
--to=bvanassche@acm.org \
--cc=chanho.min@lge.com \
--cc=eike-kernel@sf-tec.de \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).