From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>,
Mike Christie <michaelc@cs.wisc.edu>, Tejun Heo <tj@kernel.org>,
Chanho Min <chanho.min@lge.com>
Subject: Re: [PATCH v7 4/9] Remove offline devices when removing a host
Date: Fri, 07 Dec 2012 16:10:20 +0100 [thread overview]
Message-ID: <50C206DC.3040202@suse.de> (raw)
In-Reply-To: <50C0C00E.60709@acm.org>
On 12/06/2012 04:55 PM, Bart Van Assche wrote:
> Currently __scsi_remove_device() skips devices that are visible and
> offline. Make sure that these devices get removed by changing their
> device state into SDEV_DEL at the start of __scsi_remove_device().
> Also, avoid that __scsi_remove_device() gets called a second time
> for devices that are in state SDEV_CANCEL when scsi_forget_host()
> is invoked.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> Cc: James Bottomley <JBottomley@Parallels.com>
> Cc: Mike Christie <michaelc@cs.wisc.edu>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Tejun Heo <tj@kernel.org>
> ---
> drivers/scsi/scsi_scan.c | 2 +-
> drivers/scsi/scsi_sysfs.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 3e58b22..0612fba 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -1889,7 +1889,7 @@ void scsi_forget_host(struct Scsi_Host *shost)
> restart:
> spin_lock_irqsave(shost->host_lock, flags);
> list_for_each_entry(sdev, &shost->__devices, siblings) {
> - if (sdev->sdev_state == SDEV_DEL)
> + if (scsi_device_being_removed(sdev))
> continue;
> spin_unlock_irqrestore(shost->host_lock, flags);
> __scsi_remove_device(sdev);
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 2ff7ba5..4348f12 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -959,8 +959,8 @@ void __scsi_remove_device(struct scsi_device *sdev)
> unsigned long flags;
>
> if (sdev->is_visible) {
> - if (scsi_device_set_state(sdev, SDEV_CANCEL) != 0)
> - return;
> + WARN_ON_ONCE(scsi_device_set_state(sdev, SDEV_CANCEL) != 0 &&
> + scsi_device_set_state(sdev, SDEV_DEL) != 0);
>
> bsg_unregister_queue(sdev->request_queue);
> device_unregister(&sdev->sdev_dev);
>
Hmm. Then we would be getting a warning if the device is already in
SDEV_DEL, wouldn't we?
And what about offlined devices?
We should be safe to remove them, or?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-12-07 15:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 15:51 [PATCH v7 0/9] More device removal fixes Bart Van Assche
2012-12-06 15:52 ` [PATCH v7 1/9] Fix race between starved list processing and device removal Bart Van Assche
[not found] ` <034101cdee08$2d67f870$8837e950$@min@lge.com>
2013-02-09 15:06 ` Bart Van Assche
2012-12-06 15:53 ` [PATCH v7 2/9] Remove get_device() / put_device() pair from scsi_request_fn() Bart Van Assche
2012-12-06 15:55 ` [PATCH v7 3/9] Introduce scsi_device_being_removed() Bart Van Assche
2012-12-07 6:48 ` Hannes Reinecke
2012-12-07 8:40 ` Rolf Eike Beer
2012-12-07 9:11 ` Bart Van Assche
2012-12-07 10:02 ` Rolf Eike Beer
2012-12-07 12:43 ` Bart Van Assche
2012-12-07 13:41 ` Rolf Eike Beer
2012-12-06 15:55 ` [PATCH v7 4/9] Remove offline devices when removing a host Bart Van Assche
2012-12-07 15:10 ` Hannes Reinecke [this message]
2012-12-07 15:33 ` Bart Van Assche
2012-12-07 17:21 ` Bart Van Assche
2012-12-06 15:56 ` [PATCH v7 5/9] Disallow changing the device state via sysfs into "deleted" Bart Van Assche
2012-12-07 6:55 ` Hannes Reinecke
2012-12-07 12:46 ` Bart Van Assche
2012-12-07 13:33 ` Bart Van Assche
2012-12-07 13:36 ` Hannes Reinecke
2012-12-06 15:57 ` [PATCH v7 6/9] Avoid saving/restoring interrupt state inside scsi_remove_host() Bart Van Assche
2012-12-07 6:55 ` Hannes Reinecke
2012-12-06 15:58 ` [PATCH v7 7/9] Make scsi_remove_host() wait for device removal Bart Van Assche
2012-12-06 15:59 ` [PATCH v7 8/9] Make scsi_remove_host() wait until error handling finished Bart Van Assche
2012-12-07 6:58 ` Hannes Reinecke
2012-12-06 16:00 ` [PATCH v7 9/9] Avoid that scsi_device_set_state() triggers a race Bart Van Assche
2012-12-07 6:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C206DC.3040202@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=chanho.min@lge.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).