From: Bart Van Assche <bvanassche@acm.org>
To: Robert Love <robert.w.love@intel.com>
Cc: linux-scsi@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH 03/16] libfcoe: Save some memory and optimize name lookups
Date: Thu, 13 Dec 2012 08:54:10 +0100 [thread overview]
Message-ID: <50C989A2.2070400@acm.org> (raw)
In-Reply-To: <20121212232219.13084.99143.stgit@fritz>
On 12/13/12 00:22, Robert Love wrote:
> @@ -210,25 +210,23 @@ static ssize_t show_fcoe_fcf_device_##field(struct device *dev, \
> #define fcoe_enum_name_search(title, table_type, table) \
> static const char *get_fcoe_##title##_name(enum table_type table_key) \
> { \
> - int i; \
> - char *name = NULL; \
> - \
> - for (i = 0; i < ARRAY_SIZE(table); i++) { \
> - if (table[i].value == table_key) { \
> - name = table[i].name; \
> - break; \
> - } \
> - } \
> - return name; \
> + if (table_key >= ARRAY_SIZE(table)) \
> + return NULL; \
> + return table[table_key]; \
> }
The old code was safe if table_key < 0 but the new code not. Can
table_key be negative ?
> +static char *fip_conn_type_names[] = {
> + [ FIP_CONN_TYPE_UNKNOWN ] = "Unknown",
> + [ FIP_CONN_TYPE_FABRIC ] = "Fabric",
> + [ FIP_CONN_TYPE_VN2VN ] = "VN2VN",
> +};
A minor nit: indentation style is inconsistent here. Two elements are
indented with a tab and another with eight spaces.
Bart.
next prev parent reply other threads:[~2012-12-13 7:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 23:22 [PATCH 00/16] libfc, libfcoe and fcoe updates for 3.8 Robert Love
2012-12-12 23:22 ` [PATCH 01/16] libfc: fix REC handling Robert Love
2012-12-12 23:22 ` [PATCH 02/16] Documentation: Add missing devices/ to devices path Robert Love
2012-12-12 23:22 ` [PATCH 03/16] libfcoe: Save some memory and optimize name lookups Robert Love
2012-12-13 7:54 ` Bart Van Assche [this message]
2012-12-14 18:36 ` Love, Robert W
2012-12-14 22:02 ` [PATCH v2] " Robert Love
2012-12-17 14:26 ` Neil Horman
2012-12-12 23:22 ` [PATCH 04/16] libfcoe: Add fcoe_sysfs debug logging level Robert Love
2012-12-12 23:22 ` [PATCH 05/16] libfcoe, fcoe, bnx2fc: Add new fcoe control interface Robert Love
2012-12-16 19:50 ` Bhanu Prakash Gollapudi
2012-12-12 23:22 ` [PATCH 06/16] fcoe: Use the fcoe_sysfs " Robert Love
2012-12-12 23:22 ` [PATCH 07/16] bnx2fc: " Robert Love
2012-12-12 23:22 ` [PATCH 08/16] libfc, libfcoe, fcoe: Convert debug_logging macros to pr_info Robert Love
2012-12-12 23:22 ` [PATCH 09/16] fcoe: prep work to start consolidate the usage of fcoe_netdev Robert Love
2012-12-12 23:22 ` [PATCH 10/16] fcoe: add support to the get_netdev() for fcoe_interface Robert Love
2012-12-12 23:23 ` [PATCH 11/16] libfcoe, fcoe: move fcoe_link_speed_update() to libfcoe and export it Robert Love
2012-12-12 23:23 ` [PATCH 12/16] libfcoe, fcoe: consolidate the fcoe_ctlr_get_lesb/fcoe_get_lesb Robert Love
2012-12-12 23:23 ` [PATCH 13/16] bnx2fc: add support to get_netdev for bnx2f_interface Robert Love
2012-12-12 23:23 ` [PATCH 14/16] bnx2fc: use fcoe_link_speed_update() from the exported symbol in libfcoe Robert Love
2012-12-12 23:23 ` [PATCH 15/16] bnx2fc: use fcoe_get_lesb/fcoe_ctlr_get_lesb() directly from libfcoe Robert Love
2012-12-12 23:23 ` [PATCH 16/16] debris left by "[SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks" Robert Love
2012-12-16 19:56 ` [PATCH 00/16] libfc, libfcoe and fcoe updates for 3.8 Bhanu Prakash Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C989A2.2070400@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).