From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH v8 0/10] More device removal fixes Date: Sat, 09 Feb 2013 10:28:09 +0100 Message-ID: <511616A9.7040904@acm.org> References: <5110FE98.8030209@acm.org> <5113910D.2060100@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gerard.telenet-ops.be ([195.130.132.48]:54694 "EHLO gerard.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972Ab3BIJ2N (ORCPT ); Sat, 9 Feb 2013 04:28:13 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Joe Lawrence Cc: linux-scsi , James Bottomley , Mike Christie , Tejun Heo , Chanho Min , David Milburn On 02/09/13 00:29, Joe Lawrence wrote: > I haven't had time to rerun the test without the two patches that wait in > scsi_remove_host(), however I did rerun the test and verify the same > behavior as in my earlier mail. I didn't see any __scsi_remove_device() > instances running. > > Some more investigation revealed that MD RAID was holding a reference to > the removed device. (In short, mdadm --remove had failed and left the > device as a faulty member of the array.) When I did finally manage to > kick that disk from the MD device, scsi host/device removal continued to > completion as expected. > > There's a bit more context to the MD situation that I'll post to the raid > list once I get the details together for Neil. I will CC you if you are > interested in following. The loop in scsi_remove_host() waits too long. It should stop waiting as soon as the blk_cleanup_queue() calls for all sdev's have finished instead of waiting until all sdev users have closed these sdev's. I will repost patches 07/10 and 08/10. Bart.