From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: device-mapper development <dm-devel@redhat.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Alasdair G Kergon <agk@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Mike Snitzer <snitzer@redhat.com>, Tejun Heo <tj@kernel.org>,
James Bottomley <JBottomley@parallels.com>
Subject: Re: [PATCH v2 0/2] dm: Avoid use-after-free of a mapped device
Date: Fri, 01 Mar 2013 17:18:54 +0900 [thread overview]
Message-ID: <5130646E.1010803@ce.jp.nec.com> (raw)
In-Reply-To: <512F54D0.5030405@acm.org>
On 02/28/13 22:00, Bart Van Assche wrote:
> How about reposting these patches as a performance optimization ?
How and when do they improve performance?
> With these patches I see a slightly lower latency and slightly higher
> throughput. With a dm-linear mapping on top of a RAM disk (brd), a
> request size of 512 bytes and 100% reads fio reports 2063K IOPS without
> these patches and 2083K IOPS with these two patches applied. That's an
> improvement of about 1%. It's not much but that comes on top of the
dm-linear + brd is not appropriate for testing your patches.
They are both bio-based drivers while your patches change request
processing. To test the patches, you have to use request-based drivers,
e.g. dm-multipath on top of scsi.
Also, IMO, the measurement should be done not only for IO performance
but also how other processes are interrupted by IO processing.
The use of blk_run_queue_async should have reduced the foot print of
softirq handling.
--
Jun'ichi Nomura, NEC Corporation
prev parent reply other threads:[~2013-03-01 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 14:45 [PATCH v2 0/2] dm: Avoid use-after-free of a mapped device Bart Van Assche
2013-02-27 14:47 ` [PATCH v2 1/2] block: Convert blk_run_queue() recursion into iteration Bart Van Assche
2013-02-27 14:48 ` [PATCH v2 2/2] dm: Avoid running the md queue after the last dm_put() Bart Van Assche
2013-02-28 0:42 ` [PATCH v2 0/2] dm: Avoid use-after-free of a mapped device Jun'ichi Nomura
2013-02-28 13:00 ` Bart Van Assche
2013-03-01 8:18 ` Jun'ichi Nomura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130646E.1010803@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=JBottomley@parallels.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox