From: Jeremy Linton <jlinton@tributary.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Hannes Reinecke <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
James Smart <james.smart@emulex.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Chad Dupuis <chad.dupuis@qlogic.com>,
Krishna C Gudipati <kgudipat@brocade.com>,
James Bottomley <jbottomley@parallels.com>
Subject: Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset
Date: Thu, 7 Mar 2013 14:35:45 -0600 [thread overview]
Message-ID: <5138FA21.8000000@tributary.com> (raw)
In-Reply-To: <5138F67D.3070703@cs.wisc.edu>
On 3/7/2013 2:20 PM, Mike Christie wrote:
> On 03/07/2013 02:13 PM, Jeremy Linton wrote:
>> For lpfc, you never get to the code. Or rather when I was testing it, I
>> couldn't find any way to propagate an error beyond the initial
>> lpfc_reset_flush_io_context() call in lpfc_device_reset_handler().
>>
>> That call pretty much always returns success indpependent of the remote
>> device because the firmware acks the context clear aborts, resulting in the
>> outstanding iocb count being zero (independent of both the mid layer status
>> and the actual device state).
>>
>
> Your lpfc patch fixes that right?
Yes. It allows the device reset to fail if the device doesn't respond to the
task mgmt request, or rejects it, etc.
It doesn't unjam the commands that get aborted by the flush_io_context() call.
Those have to depend on their timeouts. That is another patch...
next prev parent reply other threads:[~2013-03-07 20:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 8:23 [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset Hannes Reinecke
2012-12-11 12:46 ` Martin Peschke
2012-12-11 14:06 ` Hannes Reinecke
2013-03-07 19:19 ` Mike Christie
2013-03-07 20:13 ` Jeremy Linton
2013-03-07 20:20 ` Mike Christie
2013-03-07 20:24 ` Mike Christie
2013-03-07 20:35 ` Jeremy Linton [this message]
2013-03-11 17:05 ` Hannes Reinecke
2013-03-11 18:04 ` James Smart
2013-03-11 18:32 ` Vijay Mohan Guvva
2013-03-12 15:59 ` Hannes Reinecke
2013-03-07 21:44 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5138FA21.8000000@tributary.com \
--to=jlinton@tributary.com \
--cc=andrew.vasquez@qlogic.com \
--cc=chad.dupuis@qlogic.com \
--cc=hare@suse.de \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=kgudipat@brocade.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox