From: "Jack Wang" <jack_wang@usish.com>
To: 'Dan Williams' <dan.j.williams@intel.com>, linux-scsi@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Subject: RE: [PATCH v3 12/14] isci: ->lldd_ata_check_ready handler
Date: Mon, 9 Jan 2012 09:57:36 +0800 [thread overview]
Message-ID: <513F55D9529643AC8F6F4C5B4B9F4B9D@usish.com.cn> (raw)
In-Reply-To: <20120106010001.11464.91347.stgit@localhost6.localdomain6>
> +int isci_ata_check_ready(struct domain_device *dev)
> +{
> + struct isci_port *iport = dev->port->lldd_port;
> + struct isci_host *ihost = dev_to_ihost(dev);
> + struct isci_remote_device *idev;
> + unsigned long flags;
> + int rc = 0;
> +
> + spin_lock_irqsave(&ihost->scic_lock, flags);
> + idev = isci_lookup_device(dev);
> + spin_unlock_irqrestore(&ihost->scic_lock, flags);
> +
> + if (!idev)
> + goto out;
> +
> + if (test_bit(IPORT_RESET_PENDING, &iport->state))
> + goto out;
> +
> + /* snapshot active phy mask */
> + spin_lock_irqsave(&ihost->scic_lock, flags);
> + rc = !!iport->active_phy_mask;
[Jack Wang]
Hi Dan,
Could you explain why here you not directly use "
rc = !!iport->active_phy_mask;
"
> + spin_unlock_irqrestore(&ihost->scic_lock, flags);
> + out:
> + isci_put_device(idev);
> +
> + return rc;
> +}
> +
> void isci_port_deformed(struct asd_sas_phy *phy)
> {
> struct isci_host *ihost = phy->ha->lldd_ha;
> diff --git a/drivers/scsi/isci/port.h b/drivers/scsi/isci/port.h
> index 78e1e82..b4a733c 100644
> --- a/drivers/scsi/isci/port.h
> +++ b/drivers/scsi/isci/port.h
> @@ -293,4 +293,5 @@ void isci_port_init(
>
> int isci_port_perform_hard_reset(struct isci_host *ihost, struct
isci_port
> *iport,
> struct isci_phy *iphy);
> +int isci_ata_check_ready(struct domain_device *dev);
> #endif /* !defined(_ISCI_PORT_H_) */
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-09 1:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 0:59 [GIT PATCH v3 00/14] libsas: eh reworks (ata-eh vs discovery, races, ...) Dan Williams
2012-01-06 0:59 ` [PATCH v3 01/14] libsas: introduce sas_drain_work() Dan Williams
2012-01-06 0:59 ` [PATCH v3 02/14] libsas: remove ata_port.lock management duties from lldds Dan Williams
2012-01-06 0:59 ` [PATCH v3 03/14] libsas: prevent domain rediscovery competing with ata error handling Dan Williams
2012-01-09 19:14 ` Dan Williams
2012-01-09 20:03 ` Dan Williams
2012-01-06 0:59 ` [PATCH v3 04/14] libsas: fix timeout vs completion race Dan Williams
2012-01-06 0:59 ` [PATCH v3 05/14] libsas: perform sas-transport resets in shost->workq context Dan Williams
2012-01-06 0:59 ` [PATCH v3 06/14] libsas: sas_phy_enable via transport_sas_phy_reset Dan Williams
2012-01-06 0:59 ` [PATCH v3 07/14] libsas: async ata-eh Dan Williams
2012-01-06 0:59 ` [PATCH v3 08/14] isci: kill iphy->isci_port lookups Dan Williams
2012-01-23 23:45 ` Dan Williams
2012-01-06 0:59 ` [PATCH v3 09/14] isci: kill isci_port->status Dan Williams
2012-01-06 0:59 ` [PATCH v3 10/14] isci: fix interpretation of "hard" reset Dan Williams
2012-01-06 0:59 ` [PATCH v3 11/14] isci: stop interpreting ->lldd_lu_reset() as an ata soft-reset Dan Williams
2012-01-06 1:00 ` [PATCH v3 12/14] isci: ->lldd_ata_check_ready handler Dan Williams
2012-01-09 1:57 ` Jack Wang [this message]
2012-01-09 19:26 ` Dan Williams
2012-01-06 1:00 ` [PATCH v3 13/14] isci: remove bus and reset handlers Dan Williams
2012-01-06 1:00 ` [PATCH v3 14/14] isci: remove IDEV_EH hack to disable "discovery-time" ata resets Dan Williams
2012-01-06 1:46 ` [GIT PATCH v3 00/14] libsas: eh reworks (ata-eh vs discovery, races, ...) Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F55D9529643AC8F6F4C5B4B9F4B9D@usish.com.cn \
--to=jack_wang@usish.com \
--cc=dan.j.williams@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox