Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds

Martin K. Petersen
2025-03-04T02:25:36Z

Joel,

> 1. Having the upper bound be SYSCTL_INT_MAX is not necessary (as it is
> silently capped by proc_dointvec_minmax, but it is good to have as it
> adds to the understanding on what the range of the values are.
>
> 2. Having the lower bound capped by SYSCTL_ZERO is needed as it will
> prevent ppl trying to assigning negative values to the unsigned integer
>
> Let me know if you take this through the scsi subsystem so I know to
> drop it from sysctl

Applied to 6.15/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering