Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds

Joel Granados
2025-03-05T14:45:01Z

On Mon, Mar 03, 2025 at 09:24:43PM -0500, Martin K. Petersen wrote:
>
> Joel,
>
> > 1. Having the upper bound be SYSCTL_INT_MAX is not necessary (as it is
> > silently capped by proc_dointvec_minmax, but it is good to have as it
> > adds to the understanding on what the range of the values are.
> >
> > 2. Having the lower bound capped by SYSCTL_ZERO is needed as it will
> > prevent ppl trying to assigning negative values to the unsigned integer
> >
> > Let me know if you take this through the scsi subsystem so I know to
> > drop it from sysctl
>
> Applied to 6.15/scsi-staging, thanks!
Thx!!

@Nicolas: Please take this out of your next version as it is already
going upstream.

Best

>
> --
> Martin K. Petersen Oracle Linux Engineering

--

Joel Granados