From: Mike Christie <michaelc@cs.wisc.edu>
To: michaelc@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org, Masatake YAMATO <yamato@redhat.com>
Subject: Re: [PATCH 1/2] libiscsi: avoid unnecessary multiple NULL assignments
Date: Wed, 10 Apr 2013 11:28:04 -0500 [thread overview]
Message-ID: <51659314.1050404@cs.wisc.edu> (raw)
In-Reply-To: <1365611079-15011-2-git-send-email-michaelc@cs.wisc.edu>
On 04/10/2013 11:24 AM, michaelc@cs.wisc.edu wrote:
> From: Masatake YAMATO <yamato@redhat.com>
>
> In iscsi_free_task, NULL is assigned to task->sc twice: before and
> after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded
> with session->lock, so multiple NULL assignments cause no trouble. But
> people reading the source code may be confused.
>
> The second NULL assignment comes from commit:
>
> 3e5c28ad0391389959ccae81c938c7533efb3490
>
> It seems that the line after kfifo_in invocation was introduced
> accidentally.
>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Sorry about the incorrect signed of chain James. When I sent/made the
patches I added both a reviewed-by and signed-off to this one by accident.
Masatake made the patch. I am just resending to the list.
next prev parent reply other threads:[~2013-04-10 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 16:24 [PATCH 0/2] iscsi changes for scsi misc michaelc
2013-04-10 16:24 ` [PATCH 1/2] libiscsi: avoid unnecessary multiple NULL assignments michaelc
2013-04-10 16:28 ` Mike Christie [this message]
2013-04-10 16:24 ` [PATCH 2/2] iscsi_tcp: support PF_MEMALLOC/__GFP_MEMALLOC michaelc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51659314.1050404@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=linux-scsi@vger.kernel.org \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).