From: Benny Halevy <bhalevy@tonian.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
kernel-janitors@vger.kernel.org, osd-dev@open-osd.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Subject: Re: [osd-dev] [patch] [SCSI] libosd: remover duplicate __bitwise annotation
Date: Wed, 17 Apr 2013 11:32:51 +0300 [thread overview]
Message-ID: <516E5E33.1090506@tonian.com> (raw)
In-Reply-To: <20130417071905.GE7923@elgon.mountain>
On 2013-04-17 10:19, Dan Carpenter wrote:
> __be32 is already a __bitwise type so we don't need the second __bitwise
> here. It causes a Sparse error:
> include/scsi/osd_protocol.h:110:26: error: invalid modifier
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
ACK
>
> diff --git a/include/scsi/osd_protocol.h b/include/scsi/osd_protocol.h
> index a6026da..25ac628 100644
> --- a/include/scsi/osd_protocol.h
> +++ b/include/scsi/osd_protocol.h
> @@ -107,7 +107,7 @@ enum osd_attributes_mode {
> * int exponent: 04;
> * }
> */
> -typedef __be32 __bitwise osd_cdb_offset;
> +typedef __be32 osd_cdb_offset;
>
> enum {
> OSD_OFFSET_UNUSED = 0xFFFFFFFF,
> _______________________________________________
> osd-dev mailing list
> osd-dev@open-osd.org
> http://mailman.open-osd.org/mailman/listinfo/osd-dev
>
prev parent reply other threads:[~2013-04-17 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 7:19 [patch] [SCSI] libosd: remover duplicate __bitwise annotation Dan Carpenter
2013-04-17 8:32 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E5E33.1090506@tonian.com \
--to=bhalevy@tonian.com \
--cc=JBottomley@parallels.com \
--cc=bharrosh@panasas.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox