From: Subhash Jadavani <subhashj@codeaurora.org>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: 'Sujit Reddy Thumma' <sthumma@codeaurora.org>,
linux-scsi@vger.kernel.org,
'Vinayak Holikatti' <vinholikatti@gmail.com>,
'Santosh Y' <santoshsy@gmail.com>,
"'James E.J. Bottomley'" <JBottomley@parallels.com>
Subject: Re: [PATCH 2/5] scsi: ufs: wrap the i/o access operations
Date: Tue, 30 Apr 2013 16:53:22 +0530 [thread overview]
Message-ID: <517FA9AA.1060101@codeaurora.org> (raw)
In-Reply-To: <000b01ce423b$d626e520$8274af60$%jun@samsung.com>
On 4/26/2013 10:36 AM, Seungwon Jeon wrote:
> Hi,
>
> On Thursday, April 25, 2013, Sujit Reddy Thumma wrote:
>> On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
>>> Simplify operations with hiding mmio_base.
>>>
>>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>>> ---
>>> drivers/scsi/ufs/ufshcd.c | 106 +++++++++++++++++++--------------------------
>>> drivers/scsi/ufs/ufshcd.h | 5 ++
>>> 2 files changed, 49 insertions(+), 62 deletions(-)
>>>
>>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>>> index 1680394..6728450 100644
>>> --- a/drivers/scsi/ufs/ufshcd.h
>>> +++ b/drivers/scsi/ufs/ufshcd.h
>>> @@ -190,4 +190,9 @@ int ufshcd_init(struct device *, struct ufs_hba ** , void __iomem * ,
>>> unsigned int);
>>> void ufshcd_remove(struct ufs_hba *);
>>>
>>> +#define ufshcd_writel(hba, reg, val) \
>> Let this be consistent with writel() arguments - "val" as second arg and
>> "reg" as third?
> You got a point there.
> When considering an array of arguments in two functions and value part can be some long expression,
> I think it seems more coherent.
> ufshcd_readl(hba, reg);
> ufshcd_writel(hba, reg, val);
> How about keeping these?
I somehow tend to agree with what Sujit suggested. Its good to be
consitent with writel() for better code readability.
>
> Thanks,
> Seungwon Jeon
>
>>> + writel((val), (hba)->mmio_base + (reg))
>>> +#define ufshcd_readl(hba, reg) \
>>> + readl((hba)->mmio_base + (reg))
>>> +
>>> #endif /* End of Header */
>>>
>> --
>> Regards,
>> Sujit
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-04-30 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 16:06 [PATCH 2/5] scsi: ufs: wrap the i/o access operations Seungwon Jeon
2013-04-25 4:49 ` Sujit Reddy Thumma
2013-04-26 5:06 ` Seungwon Jeon
2013-04-30 11:23 ` Subhash Jadavani [this message]
2013-05-01 7:49 ` merez
2013-05-02 7:00 ` Seungwon Jeon
2013-05-04 8:45 ` [PATCH v2 2/7] " Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FA9AA.1060101@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
--cc=tgih.jun@samsung.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox