From: Bart Van Assche <bvanassche@acm.org>
To: James Bottomley <jbottomley@parallels.com>
Cc: "wenxiong@linux.vnet.ibm.com" <wenxiong@linux.vnet.ibm.com>,
Hannes Reinecke <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd
Date: Sat, 04 May 2013 19:02:48 +0200 [thread overview]
Message-ID: <51853F38.9040805@acm.org> (raw)
In-Reply-To: <1367605401.5981.45.camel@dabdike>
On 05/03/13 20:23, James Bottomley wrote:
> + const unsigned long stall_for = min(msecs_to_jiffies(10), 1UL);
Hello James,
Can you please clarify what the intention of this statement is ? Is the
purpose of this statement to avoid that stall_for would be zero in case
HZ < 100 ? If that is the case, maybe you meant max() instead of min() ?
Also, are you aware that msecs_to_jiffies() already rounds up the result
of the division ?
Bart.
next prev parent reply other threads:[~2013-05-04 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 6:10 [PATCH] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd Hannes Reinecke
2013-05-03 14:24 ` wenxiong
2013-05-03 18:23 ` James Bottomley
2013-05-04 17:02 ` Bart Van Assche [this message]
2013-05-04 18:20 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51853F38.9040805@acm.org \
--to=bvanassche@acm.org \
--cc=brking@linux.vnet.ibm.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox