Re: [PATCH] scsi: Allow error handling timeout to be specified

Bart Van Assche
2013-05-10T06:23:50Z

On 05/10/13 05:11, Martin K. Petersen wrote:
> Introduce eh_timeout which can be used for error handling purposes. This
> was previously hardcoded to 10 seconds in the SCSI error handling
> code. However, for some fast-fail scenarios it is necessary to be able
> to tune this as it can take several iterations (bus device, target, bus,
> controller) before we give up.

Hello Martin,

sdev->max_queue_depth = sdev->queue_depth;
+ sdev->eh_timeout = SCSI_DEFAULT_EH_TIMEOUT;

Have you considered to move the eh_timeout assignment statement to just
before the transport_configure_device() and slave_configure() calls ?
That would allow transport drivers and LLD drivers to override the
default eh_timeout value.

Bart.