From: John Garry <john.garry@huawei.com>
To: Qian Cai <cai@redhat.com>, <axboe@kernel.dk>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<don.brace@microsemi.com>, <kashyap.desai@broadcom.com>,
<ming.lei@redhat.com>, <bvanassche@acm.org>,
<dgilbert@interlog.com>, <paolo.valente@linaro.org>,
<hare@suse.de>, <hch@lst.de>
Cc: <sumit.saxena@broadcom.com>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<esc.storagedev@microsemi.com>, <megaraidlinux.pdl@broadcom.com>,
<chenxiang66@hisilicon.com>, <luojiaxing@huawei.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v8 17/18] scsi: megaraid_sas: Added support for shared host tagset for cpuhotplug
Date: Tue, 3 Nov 2020 10:54:15 +0000 [thread overview]
Message-ID: <519e0d58-e73e-22ce-0ddb-1be71487ba6d@huawei.com> (raw)
In-Reply-To: <193a0440eed447209c48bda042f0e4db102355e7.camel@redhat.com>
On 02/11/2020 15:18, Qian Cai wrote:
> On Mon, 2020-11-02 at 14:51 +0000, John Garry wrote:
>> On 02/11/2020 14:17, Qian Cai wrote:
>>> [ 251.961152][ T330] INFO: task systemd-udevd:567 blocked for more than
>>> 122 seconds.
>>> [ 251.968876][ T330] Not tainted 5.10.0-rc1-next-20201102 #1
>>> [ 251.975003][ T330] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
>>> disables this message.
>>> [ 251.983546][ T330] task:systemd-udevd state:D stack:27224 pid: 567
>>> ppid: 506 flags:0x00004324
>>> [ 251.992620][ T330] Call Trace:
>>> [ 251.995784][ T330] __schedule+0x71d/0x1b60
>>> [ 252.000067][ T330] ? __sched_text_start+0x8/0x8
>>> [ 252.004798][ T330] schedule+0xbf/0x270
>>> [ 252.008735][ T330] schedule_timeout+0x3fc/0x590
>>> [ 252.013464][ T330] ? usleep_range+0x120/0x120
>>> [ 252.018008][ T330] ? wait_for_completion+0x156/0x250
>>> [ 252.023176][ T330] ? lock_downgrade+0x700/0x700
>>> [ 252.027886][ T330] ? rcu_read_unlock+0x40/0x40
>>> [ 252.032530][ T330] ? do_raw_spin_lock+0x121/0x290
>>> [ 252.037412][ T330] ? lockdep_hardirqs_on_prepare+0x27c/0x3d0
>>> [ 252.043268][ T330] ? _raw_spin_unlock_irq+0x1f/0x30
>>> [ 252.048331][ T330] wait_for_completion+0x15e/0x250
>>> [ 252.053323][ T330] ? wait_for_completion_interruptible+0x320/0x320
>>> [ 252.059687][ T330] ? lockdep_hardirqs_on_prepare+0x27c/0x3d0
>>> [ 252.065543][ T330] ? _raw_spin_unlock_irq+0x1f/0x30
>>> [ 252.070606][ T330] __flush_work+0x42a/0x900
>>> [ 252.074989][ T330] ? queue_delayed_work_on+0x90/0x90
>>> [ 252.080139][ T330] ? __queue_work+0x463/0xf40
>>> [ 252.084700][ T330] ? init_pwq+0x320/0x320
>>> [ 252.088891][ T330] ? queue_work_on+0x5e/0x80
>>> [ 252.093364][ T330] ? trace_hardirqs_on+0x1c/0x150
>>> [ 252.098255][ T330] work_on_cpu+0xe7/0x130
>>> [ 252.102461][ T330] ? flush_delayed_work+0xc0/0xc0
>>> [ 252.107342][ T330] ? __mutex_unlock_slowpath+0xd4/0x670
>>> [ 252.112764][ T330] ? work_debug_hint+0x30/0x30
>>> [ 252.117391][ T330] ? pci_device_shutdown+0x80/0x80
>>> [ 252.122378][ T330] ? cpumask_next_and+0x57/0x80
>>> [ 252.127094][ T330] pci_device_probe+0x500/0x5c0
>>> [ 252.131824][ T330] ? pci_device_remove+0x1f0/0x1f0
>>
>> Is CONFIG_DEBUG_TEST_DRIVER_REMOVE enabled? I figure it is, with this call.
>>
>> Or please share the .config
>
> No. https://cailca.coding.net/public/linux/mm/git/files/master/x86.config
>
thanks, FWIW, I just tested another megaraid sas card on linux-next 02
Nov with vanilla arm64 defconfig and no special commandline param, and
found no issue:
dmesg | grep mega
[30.031739] megasas: 07.714.04.00-rc1
[30.039749] megaraid_sas 0000:08:00.0: Adding to iommu group 0
[30.053247] megaraid_sas 0000:08:00.0: BAR:0x0 BAR's
base_addr(phys):0x0000080010000000 mapped virt_addr:0x(____ptrval____)
[30.053251] megaraid_sas 0000:08:00.0: FW now in Ready state
[30.065162] megaraid_sas 0000:08:00.0: 63 bit DMA mask and 63 bit
consistent mask
[30.081197] megaraid_sas 0000:08:00.0: firmware supports msix : (128)
[30.096349] megaraid_sas 0000:08:00.0: requested/available msix 128/128
[30.110277] megaraid_sas 0000:08:00.0: current msix/online cpus: (128/128)
[30.124917] megaraid_sas 0000:08:00.0: RDPQ mode : (enabled)
[30.136821] megaraid_sas 0000:08:00.0: Current firmware supports maximum
commands: 4077 LDIO threshold: 0
[30.208538] megaraid_sas 0000:08:00.0: Performance mode :Latency
(latency index = 1)
[30.224838] megaraid_sas 0000:08:00.0: FW supports sync cache : Yes
[30.238021] megaraid_sas 0000:08:00.0: megasas_disable_intr_fusion is
called outbound_intr_mask:0x40000009
[30.311960] megaraid_sas 0000:08:00.0: FW provided supportMaxExtLDs: 1
max_lds: 64
[30.327885] megaraid_sas 0000:08:00.0: controller type : MR(2048MB)
[30.341066] megaraid_sas 0000:08:00.0: Online Controller Reset(OCR) :
Enabled
[30.356076] megaraid_sas 0000:08:00.0: Secure JBOD support: Yes
[30.368710] megaraid_sas 0000:08:00.0: NVMe passthru support : Yes
[30.381708] megaraid_sas 0000:08:00.0: FW provided TM TaskAbort/Reset
timeout : 6 secs/60 secs
[30.399825] megaraid_sas 0000:08:00.0: JBOD sequence map support : Yes
[30.413552] megaraid_sas 0000:08:00.0: PCI Lane Margining support : No
[30.452059] megaraid_sas 0000:08:00.0: NVME page size : (4096)
[30.465079] megaraid_sas 0000:08:00.0: megasas_enable_intr_fusion is
called outbound_intr_mask:0x40000000
[30.485208] megaraid_sas 0000:08:00.0: INIT adapter done
[30.496609] megaraid_sas 0000:08:00.0: pci id :
(0x1000)/(0x0016)/(0x19e5)/(0xd215)
[30.512931] megaraid_sas 0000:08:00.0: unevenspan support : no
[30.525199] megaraid_sas 0000:08:00.0: firmware crash dump: no
[30.537649] megaraid_sas 0000:08:00.0: JBOD sequence map : enabled
[30.550743] megaraid_sas 0000:08:00.0: Max firmware commands: 4076
shared with nr_hw_queues = 127
john@ubuntu:~$ lspci -s 08:00.0 -v
08:00.0 RAID bus controller: LSI Logic / Symbios Logic MegaRAID Tri-Mode
SAS3508 (rev 01)
Subsystem: Huawei Technologies Co., Ltd. MegaRAID Tri-Mode SAS3508
Flags: bus master, fast devsel, latency 0, IRQ 41, NUMA node 0
Memory at 80010000000 (64-bit, prefetchable) [size=1M]
Memory at 80010100000 (64-bit, prefetchable) [size=1M]
Memory at e9400000 (32-bit, non-prefetchable) [size=1M]
I/O ports at 1000 [size=256]
Expansion ROM at e9500000 [disabled] [size=1M]
Capabilities: <access denied>
Kernel driver in use: megaraid_sas
I have no x86 system to test that x86 config, though. How about
v5.10-rc2 for this issue?
Thanks,
John
>>
>> Cheers,
>> John
>>
>>> [ 252.136805][ T330] really_probe+0x207/0xad0
>>> [ 252.141191][ T330] ? device_driver_attach+0x120/0x120
>>> [ 252.146428][ T330] driver_probe_device+0x1f1/0x370
>>> [ 252.151424][ T330] device_driver_attach+0xe5/0x120
>>> [ 252.156399][ T330] __driver_attach+0xf0/0x260
>>> [ 252.160953][ T330] bus_for_each_dev+0x117/0x1a0
>>> [ 252.165669][ T330] ? subsys_dev_iter_exit+0x10/0x10
>>> [ 252.170731][ T330] bus_add_driver+0x399/0x560
>>> [ 252.175289][ T330] driver_register+0x189/0x310
>>> [ 252.179919][ T330] ? 0xffffffffc05c1000
>>> [ 252.183960][ T330] megasas_init+0x117/0x1000 [megaraid_sas]
>>> [ 252.189713][ T330] do_one_initcall+0xf6/0x510
>>> [ 252.194267][ T330] ? perf_trace_initcall_level+0x490/0x490
>>> [ 252.199940][ T330] ? kasan_unpoison_shadow+0x30/0x40
>>> [ 252.205104][ T330] ? __kasan_kmalloc.constprop.11+0xc1/0xd0
>>> [ 252.210859][ T330] ? do_init_module+0x49/0x6c0
>>> [ 252.215500][ T330] ? kmem_cache_alloc_trace+0x11f/0x1e0
>>> [ 252.220925][ T330] ? kasan_unpoison_shadow+0x30/0x40
>>> [ 252.226068][ T330] do_init_module+0x1ed/0x6c0
>>> [ 252.230608][ T330] load_module+0x4a59/0x5d20
>>> [ 252.235081][ T330] ? layout_and_allocate+0x2770/0x2770
>>> [ 252.240404][ T330] ? __vmalloc_node+0x8d/0x100
>>> [ 252.245046][ T330] ? kernel_read_file+0x485/0x5a0
>>> [ 252.249934][ T330] ? kernel_read_file+0x305/0x5a0
>>> [ 252.254839][ T330] ? __x64_sys_fsconfig+0x970/0x970
>>> [ 252.259903][ T330] ? __do_sys_finit_module+0xff/0x180
>>> [ 252.265153][ T330] __do_sys_finit_module+0xff/0x180
>>> [ 252.270216][ T330] ? __do_sys_init_module+0x1d0/0x1d0
>>> [ 252.275465][ T330] ? __fget_files+0x1c3/0x2e0
>>> [ 252.280010][ T330] do_syscall_64+0x33/0x40
>>> [ 252.284304][ T330] entry_SYSCALL_64_after_hwframe+0x44/0xa9
>>> [ 252.290054][ T330] RIP: 0033:0x7fbb3e2fa78d
>>> [ 252.294348][ T330] Code: Unable to access opcode bytes at RIP
>>> 0x7fbb3e2fa763.
>>> [ 252.301584][ T330] RSP: 002b:00007ffe572e8d18 EFLAGS: 00000246 ORIG_RAX:
>>> 0000000000000139
>>> [ 252.309855][ T330] RAX: ffffffffffffffda RBX: 000055c7795d90f0 RCX:
>>> 00007fbb3e2fa78d
>>> [ 252.317703][ T330] RDX: 0000000000000000 RSI: 00007fbb3ee6c82d RDI:
>>> 0000000000000006
>>> [ 252.325553][ T330] RBP: 00007fbb3ee6c82d R08: 0000000000000000 R09:
>>> 00007ffe572e8e40
>>> [ 252.333402][ T330] R10: 0000000000000006 R11: 0000000000000246 R12:
>>> 0000000000000000
>>> [ 252.341257][ T330] R13: 000055c7795930e0 R14: 0000000000020000 R15:
>>> 0000000000000000
>>> [ 252.349117][ T330]
>
> .
>
next prev parent reply other threads:[~2020-11-03 10:54 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 15:20 [PATCH v8 00/18] blk-mq/scsi: Provide hostwide shared tags for SCSI HBAs John Garry
2020-08-19 15:20 ` [PATCH v8 01/18] blk-mq: Rename BLK_MQ_F_TAG_SHARED as BLK_MQ_F_TAG_QUEUE_SHARED John Garry
2020-08-19 15:20 ` [PATCH v8 02/18] blk-mq: Rename blk_mq_update_tag_set_depth() John Garry
2020-08-19 15:20 ` [PATCH v8 03/18] blk-mq: Free tags in blk_mq_init_tags() upon error John Garry
2020-08-19 15:20 ` [PATCH v8 04/18] blk-mq: Pass flags for tag init/free John Garry
2020-08-19 15:20 ` [PATCH v8 05/18] blk-mq: Use pointers for blk_mq_tags bitmap tags John Garry
2020-08-19 15:20 ` [PATCH v8 06/18] blk-mq: Facilitate a shared sbitmap per tagset John Garry
2020-08-19 15:20 ` [PATCH v8 07/18] blk-mq: Relocate hctx_may_queue() John Garry
2020-08-19 15:20 ` [PATCH v8 08/18] blk-mq: Record nr_active_requests per queue for when using shared sbitmap John Garry
2020-08-19 15:20 ` [PATCH v8 09/18] blk-mq: Record active_queues_shared_sbitmap per tag_set " John Garry
2020-08-19 15:20 ` [PATCH v8 10/18] blk-mq, elevator: Count requests per hctx to improve performance John Garry
2020-08-19 15:20 ` [PATCH v8 11/18] null_blk: Support shared tag bitmap John Garry
2020-08-19 15:20 ` [PATCH v8 12/18] scsi: Add host and host template flag 'host_tagset' John Garry
2020-08-19 15:20 ` [PATCH v8 13/18] scsi: core: Show nr_hw_queues in sysfs John Garry
2020-09-10 8:33 ` John Garry
2020-08-19 15:20 ` [PATCH v8 14/18] scsi: hisi_sas: Switch v3 hw to MQ John Garry
2020-08-19 15:20 ` [PATCH v8 15/18] scsi: scsi_debug: Support host tagset John Garry
2020-08-19 15:20 ` [PATCH v8 16/18] hpsa: enable host_tagset and switch to MQ John Garry
2020-08-19 15:20 ` [PATCH v8 17/18] scsi: megaraid_sas: Added support for shared host tagset for cpuhotplug John Garry
2020-11-02 14:17 ` Qian Cai
2020-11-02 14:31 ` Kashyap Desai
2020-11-02 15:24 ` Qian Cai
2020-11-02 14:51 ` John Garry
2020-11-02 15:18 ` Qian Cai
2020-11-03 10:54 ` John Garry [this message]
2020-11-03 13:04 ` Qian Cai
2020-11-04 15:21 ` Qian Cai
2020-11-04 16:07 ` Kashyap Desai
2020-11-04 18:08 ` John Garry
2020-11-06 19:25 ` Sumit Saxena
2020-11-07 0:17 ` Qian Cai
2020-11-09 8:49 ` John Garry
2020-11-09 13:39 ` Qian Cai
2020-11-09 14:05 ` John Garry
2020-11-10 17:42 ` John Garry
2020-11-11 7:27 ` Sumit Saxena
2020-11-11 9:27 ` Ming Lei
2020-11-11 11:36 ` Sumit Saxena
2020-11-11 14:42 ` Qian Cai
2020-11-11 15:04 ` Ming Lei
2020-11-11 11:51 ` John Garry
2020-08-19 15:20 ` [PATCH v8 18/18] smartpqi: enable host tagset John Garry
2020-08-27 8:53 ` [PATCH v8 00/18] blk-mq/scsi: Provide hostwide shared tags for SCSI HBAs John Garry
2020-09-03 19:28 ` Douglas Gilbert
2020-09-03 21:23 ` Jens Axboe
2020-09-04 9:09 ` John Garry
2020-09-04 12:44 ` Martin K. Petersen
2020-09-16 7:21 ` John Garry
2020-09-17 1:10 ` Martin K. Petersen
2020-09-17 6:48 ` John Garry
2020-09-21 21:35 ` Don.Brace
2020-09-21 22:15 ` John Garry
2020-09-22 9:03 ` John Garry
2020-09-28 16:11 ` Kashyap Desai
2020-10-06 14:24 ` John Garry
2020-10-06 14:42 ` Jens Axboe
2020-09-08 12:46 ` Hannes Reinecke
2020-09-08 13:38 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519e0d58-e73e-22ce-0ddb-1be71487ba6d@huawei.com \
--to=john.garry@huawei.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cai@redhat.com \
--cc=chenxiang66@hisilicon.com \
--cc=dgilbert@interlog.com \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luojiaxing@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=ming.lei@redhat.com \
--cc=paolo.valente@linaro.org \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox