From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ipr: qc_fill_rtf() method should not store alternate status register Date: Sat, 01 Jun 2013 02:37:00 +0400 Message-ID: <51A9260C.20504@cogentembedded.com> References: <201305212324.22822.sergei.shtylyov@cogentembedded.com> <51A89BBB.1030705@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51A89BBB.1030705@linux.vnet.ibm.com> Sender: linux-ide-owner@vger.kernel.org To: Brian King , tj@kernel.org Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Hello. On 05/31/2013 04:46 PM, Brian King wrote: > >> The 'ctl' field of the 'struct ata_taskfile' is not really dual purpose, i.e. >> it is not intended for storing the alternate status register (which is mapped >> at the same address in the legacy IDE controllers) in the qc_fill_rtf() method. >> No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status >> register's value in the 'ctl' field of 'qc->result_tf', hence this driver should >> not do this as well... >> >> Signed-off-by: Sergei Shtylyov > Acked-by: Brian King > Tejun, I would prefer that this patch be merged thru the libata tree as my future cleanup patches depend on it. MBR, Sergei