From: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Cc: Joe Lawrence <joe.lawrence@stratus.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Dan Williams <dan.j.williams@gmail.com>,
linux-raid <linux-raid@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: RAID-10 keeps aborting
Date: Wed, 05 Jun 2013 13:38:20 +0200 [thread overview]
Message-ID: <51AF232C.8060209@itwm.fraunhofer.de> (raw)
In-Reply-To: <51AF0CCF.8000909@itwm.fraunhofer.de>
On 06/05/2013 12:02 PM, Bernd Schubert wrote:
> On 06/04/2013 05:39 PM, Joe Lawrence wrote:
>>
>> Just curious, what type drives were in your RAID and what does
>> /sys/class/scsi_disk/*/max_write_same_blocks report? If you have a spare
>> drive to test, maybe you could try a quick sg_write_same command to see
>> how the drive reacts?
>>
>
> I just run into the same issue with an ancient system from 2006. Except
> that I'm in hurry an need it to stress-test my own work, I can do
> anything with it - it is booted via NFS and disks are only used for
> development/testing.
>
>> (squeeze)fslab1:~# cat /sys/block/md126/queue/write_same_max_bytes
>> 16384
>
>> (squeeze)fslab1:~# cat /sys/block/sd[o,n,m,l]/queue/write_same_max_bytes
>> 0
>> 0
>> 0
>> 0
>
>
> Ah, now I found the reason why it fails, scsi-layer had set
> write_same_max_bytes to zero when it detected that it does not support
> it, but after reloading the arecal module (arcmsr) I now get:
>
>> (squeeze)fslab1:~# cat /sys/block/sd[o,n,m,l]/queue/write_same_max_bytes
>> 33553920
>> 33553920
>> 33553920
>> 33553920
In sd_config_write_same() it sets
if (sdkp->max_ws_blocks == 0)
sdkp->max_ws_blocks = SD_MAX_WS10_BLOCKS;
except when sdkp->device->no_write_same is set.
But only ata_scsi_sdev_config() sets that. And I also don't see any
driver setting max_ws_blocks, so everything except of libata gets the
default of SD_MAX_WS10_BLOCKS. This also seems to be consistent with the
33553920 I see, except that there is somewhere a bit shift.
So no surprise that mptsas and arcmsr (and anything else) devices have
write_same_max_bytes set.
As the correct handling in the md layer seems to be difficult, can we
send a fake request at device configuration time to figure out if the
device really support write-same?
next parent reply other threads:[~2013-06-05 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51AC1440.7020505@zytor.com>
[not found] ` <CAA9_cmddLfReYeAhgwh5=j6ELMBNx5Oq7Gg8K+fo0PneaEfrVA@mail.gmail.com>
[not found] ` <51AC3283.4000403@zytor.com>
[not found] ` <CAA9_cme6tYpYnrZDbrDduwPCjVn+PFbx_rZNPFazBEU9EF0upw@mail.gmail.com>
[not found] ` <51ACBAA0.40604@zytor.com>
[not found] ` <CAA9_cmc3Gs91C4aV6okUw-=q+fACm1+dooyafOZi+Lnj+Ne_ig@mail.gmail.com>
[not found] ` <51ACD511.4030604@zytor.com>
[not found] ` <yq1y5art543.fsf@sermon.lab.mkp.net>
[not found] ` <51AD2485.9000601@zytor.com>
[not found] ` <alpine.DEB.2.02.1306041132260.19072@jlaw-desktop.mno.stratus.com>
[not found] ` <51AF0CCF.8000909@itwm.fraunhofer.de>
2013-06-05 11:38 ` Bernd Schubert [this message]
2013-06-05 12:53 ` [PATCH] scsi: Check if the device support WRITE_SAME_10 Bernd Schubert
2013-06-05 19:14 ` Martin K. Petersen
2013-06-05 20:09 ` Bernd Schubert
2013-06-07 2:15 ` Martin K. Petersen
2013-06-12 19:34 ` Bernd Schubert
2013-06-05 19:11 ` RAID-10 keeps aborting Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF232C.8060209@itwm.fraunhofer.de \
--to=bernd.schubert@itwm.fraunhofer.de \
--cc=dan.j.williams@gmail.com \
--cc=hpa@zytor.com \
--cc=joe.lawrence@stratus.com \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox