From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernd Schubert Subject: Re: [PATCH] scsi: Check if the device support WRITE_SAME_10 Date: Wed, 12 Jun 2013 21:34:36 +0200 Message-ID: <51B8CD4C.8060304@itwm.fraunhofer.de> References: <51AC1440.7020505@zytor.com> <51AC3283.4000403@zytor.com> <51ACBAA0.40604@zytor.com> <51ACD511.4030604@zytor.com> <51AD2485.9000601@zytor.com> <51AF0CCF.8000909@itwm.fraunhofer.de> <51AF232C.8060209@itwm.fraunhofer.de> <51AF34E0.3030609@itwm.fraunhofer.de> <51AF9AF2.5000907@itwm.fraunhofer.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-raid-owner@vger.kernel.org To: "Martin K. Petersen" Cc: Joe Lawrence , "H. Peter Anvin" , Dan Williams , linux-raid , linux-scsi List-Id: linux-scsi@vger.kernel.org On 06/07/2013 04:15 AM, Martin K. Petersen wrote: >>>>>> "Bernd" == Bernd Schubert writes: > >>> max_t(unsigned long, max, SD_MAX_WS10_BLOCKS); > > Bernd> Max? Not min_t()? > > Brain fart. Updated patch with a few other adjustments. > > I have tested this on a couple of JBODs with a mishmash of SATA and SAS > drives, including a few specimens that report MAX WRITE SAME BLOCKS. > Thanks for the update! I'm far too long at work again, but I managed to test it now and it works fine for the ancient areca controller (ARC-1260) of this test-lab. So you may add Tested-by: Bernd Schubert and Reviewed-by: Bernd Schubert (although the latter probably does not count much for linux-scsi). Cheers, Bernd