public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladislav Bolkhovitin <ml@vlnb.net>
To: Ric Wheeler <rwheeler@redhat.com>
Cc: Chris Mason <clmason@fusionio.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <mkp@mkp.net>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: atomic write & T10 standards
Date: Wed, 03 Jul 2013 20:18:02 -0700	[thread overview]
Message-ID: <51D4E96A.6040002@vlnb.net> (raw)
In-Reply-To: <51D46E1F.1090501@redhat.com>

Ric Wheeler, on 07/03/2013 11:31 AM wrote:
>>> Journals are normally big (128MB or so?) - I don't think that this is unique to xfs.
>> We're mixing a bunch of concepts here.  The filesystems have a lot of
>> different requirements, and atomics are just one small part.
>>
>> Creating a new file often uses resources freed by past files.  So
>> deleting the old must be ordered against allocating the new.  They are
>> really separate atomic units but you can't handle them completely
>> independently.
>>
>>> If our existing journal commit is:
>>>
>>> * write the data blocks for a transaction
>>> * flush
>>> * write the commit block for the transaction
>>> * flush
>>>
>>> Which part of this does and atomic write help?
>>>
>>> We would still need at least:
>>>
>>> * atomic write of data blocks & commit blocks
>>> * flush

No necessary.

Consider a case, when you are creating many small files in a big directory. Consider
that every such operation needs 3 actions: add new directory entry, get free space and
write data there. If 1 atomic write (scattered) command is used for each operation and
you order them between each other, if needed, in some way, e.g. by using ORDERED SCSI
attribute or queue draining, you don't need any intermediate flushes. Only one final
flush would be sufficient. In case of crash simply some of the new files would
"disappear", but everything would be fully consistent, so the only needed recovery
would be to recreate them.

> The catch is that our current flush mechanisms are still pretty brute force and 
> act across either the whole device or in a temporal (everything flushed before 
> this is acked) way.
> 
> I still see it would be useful to have the atomic write really be atomic and 
> durable just for that IO - no flush needed.
> 
> Can you give a sequence for the use case for the non-durable atomic write that 
> would not need a sync?

See above.

> Can we really trust all devices to make something atomic 
> that is not durable :) ?

Sure, if application allows that and the atomicity property itself is durable, why not?

Vlad

P.S. With atomic writes there's no need in a journal, no?

  parent reply	other threads:[~2013-07-04  3:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51D4365C.1030008@redhat.com>
     [not found] ` <20130703143844.14981.69152@localhost.localdomain>
     [not found]   ` <51D43B87.5090005@redhat.com>
     [not found]     ` <1372863655.3601.19.camel@dabdike>
2013-07-03 15:04       ` atomic write & T10 standards Ric Wheeler
2013-07-03 15:21         ` Chris Mason
2013-07-03 15:22         ` James Bottomley
2013-07-03 15:27           ` Ric Wheeler
2013-07-03 15:37             ` James Bottomley
2013-07-03 15:42               ` Ric Wheeler
2013-07-03 15:54                 ` Chris Mason
2013-07-03 18:31                   ` Ric Wheeler
2013-07-03 18:54                     ` Chris Mason
2013-07-03 18:55                       ` Ric Wheeler
2013-07-04  3:18                     ` Vladislav Bolkhovitin [this message]
2013-07-04 12:34                       ` Ric Wheeler
2013-07-05 15:34                         ` Elliott, Robert (Server Storage)
2013-07-05 16:49                           ` Ric Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D4E96A.6040002@vlnb.net \
    --to=ml@vlnb.net \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=clmason@fusionio.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@mkp.net \
    --cc=rwheeler@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox