linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jack Wang <xjtuwjp@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-scsi@vger.kernel.org, AnandKumar.Santhanam@pmcs.com,
	lindar_liu@usish.com, Sangeetha.Gnanasekaran@pmcs.com,
	jinpu.wang@profitbricks.com
Subject: Re: [PATCH] pm80xx: fix Adaptec 71605H hang
Date: Mon, 15 Jul 2013 11:44:14 +0200	[thread overview]
Message-ID: <51E3C46E.8030600@gmail.com> (raw)
In-Reply-To: <51E2605D.3000301@xs4all.nl>

On 07/14/2013 10:25 AM, Hans Verkuil wrote:
> The IO command size is 128 bytes for these new controllers as opposed to 64
> for the old 8001 controller.
> 
> The Adaptec out-of-tree driver did this correctly. After comparing the two
> this turned out to be the crucial difference.
Thanks Hans for this fix.
We'd better use more meaningful Micro like:

#define MPI_IOMB_SIZE_SPCV 128 and replace current hard coded one.

Thanks,
Jack
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Acked-by: AnandKumar.Santhanam@pmcs.com
> Cc: stable@vger.kernel.org      # for v3.10 and up
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 302514d..e1db5ca 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -275,7 +275,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
>  
>  	for (i = 0; i < PM8001_MAX_SPCV_INB_NUM; i++) {
>  		pm8001_ha->inbnd_q_tbl[i].element_pri_size_cnt	=
> -			PM8001_MPI_QUEUE | (64 << 16) | (0x00<<30);
> +			PM8001_MPI_QUEUE | (128 << 16) | (0x00<<30);
>  		pm8001_ha->inbnd_q_tbl[i].upper_base_addr	=
>  			pm8001_ha->memoryMap.region[IB + i].phys_addr_hi;
>  		pm8001_ha->inbnd_q_tbl[i].lower_base_addr	=
> @@ -301,7 +301,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
>  	}
>  	for (i = 0; i < PM8001_MAX_SPCV_OUTB_NUM; i++) {
>  		pm8001_ha->outbnd_q_tbl[i].element_size_cnt	=
> -			PM8001_MPI_QUEUE | (64 << 16) | (0x01<<30);
> +			PM8001_MPI_QUEUE | (128 << 16) | (0x01<<30);
>  		pm8001_ha->outbnd_q_tbl[i].upper_base_addr	=
>  			pm8001_ha->memoryMap.region[OB + i].phys_addr_hi;
>  		pm8001_ha->outbnd_q_tbl[i].lower_base_addr	=
> 


  reply	other threads:[~2013-07-15  9:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14  8:25 [PATCH] pm80xx: fix Adaptec 71605H hang Hans Verkuil
2013-07-15  9:44 ` Jack Wang [this message]
2013-07-25  4:44   ` Anand Kumar Santhanam
2013-07-25  6:47     ` Hans Verkuil
2013-07-25  7:20       ` Anand Kumar Santhanam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E3C46E.8030600@gmail.com \
    --to=xjtuwjp@gmail.com \
    --cc=AnandKumar.Santhanam@pmcs.com \
    --cc=Sangeetha.Gnanasekaran@pmcs.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jinpu.wang@profitbricks.com \
    --cc=lindar_liu@usish.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).