From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH] pm80xx: Fix for 32 bit compilation issue. Date: Wed, 07 Aug 2013 14:14:07 +0200 Message-ID: <52023A0F.7030204@redhat.com> References: <5201FC9B.5030701@pmc-sierra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22235 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546Ab3HGMOM (ORCPT ); Wed, 7 Aug 2013 08:14:12 -0400 In-Reply-To: <5201FC9B.5030701@pmc-sierra.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Anand Cc: linux-scsi@vger.kernel.org, Sangeetha.Gnanasekaran@pmcs.com, xjtuwjp@gmail.com, Rich.Bono@pmcs.com, Nikith.Ganigarakoppal@pmcs.com On 08/07/2013 09:51 AM, Anand wrote: > From cc606631fae60a38ab9532bab79fd93523f4c579 Mon Sep 17 00:00:00 2001 > From: Anand Kumar Santhanam > Date: Mon, 5 Aug 2013 14:16:52 +0530 > Subject: [PATCH] pm80xx: Fix for 32 bit compilation issue. > > pm80xx driver does not compile under 32 bit linux. This patch > fixes the same. > > Signed-off-by: Anandkumar.Santhanam@pmcs.com > > --- > drivers/scsi/pm8001/pm8001_init.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c > index e4b9bc7..584d04e 100644 > --- a/drivers/scsi/pm8001/pm8001_init.c > +++ b/drivers/scsi/pm8001/pm8001_init.c > @@ -422,9 +422,10 @@ static int pm8001_ioremap(struct pm8001_hba_info *pm8001_ha) > pm8001_printk("PCI: bar %d, logicalBar %d ", > bar, logicalBar)); > PM8001_INIT_DBG(pm8001_ha, pm8001_printk( > - "base addr %llx virt_addr=%llx len=%d\n", > + "base addr %llx virt_addr %p len=%d\n", > (u64)pm8001_ha->io_mem[logicalBar].membase, > - (u64)pm8001_ha->io_mem[logicalBar].memvirtaddr, > + (void __iomem *) Hi Anand, the memvirtaddr is of type 'void __iomem*' - is the explicit cast needed? Tomas > + pm8001_ha->io_mem[logicalBar].memvirtaddr, > pm8001_ha->io_mem[logicalBar].memsize)); > } else { > pm8001_ha->io_mem[logicalBar].membase = 0;