Re: [PATCH] pm80xx: Fix for 32 bit compilation issue.

[Randy Dunlap <rdunlap@infradead.org>]

On 08/07/13 00:51, Anand wrote:
> From cc606631fae60a38ab9532bab79fd93523f4c579 Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>
> Date: Mon, 5 Aug 2013 14:16:52 +0530
> Subject: [PATCH] pm80xx: Fix for 32 bit compilation issue.
> 
> pm80xx driver does not compile under 32 bit linux. This patch
> fixes the same.
> 
> Signed-off-by: Anandkumar.Santhanam@pmcs.com
> 
> ---
>  drivers/scsi/pm8001/pm8001_init.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index e4b9bc7..584d04e 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -422,9 +422,10 @@ static int pm8001_ioremap(struct pm8001_hba_info *pm8001_ha)
>  				pm8001_printk("PCI: bar %d, logicalBar %d ",
>  				bar, logicalBar));
>  			PM8001_INIT_DBG(pm8001_ha, pm8001_printk(
> -				"base addr %llx virt_addr=%llx len=%d\n",
> +				"base addr %llx virt_addr %p len=%d\n",

Why are you dropping the '=' sign?

>  				(u64)pm8001_ha->io_mem[logicalBar].membase,
> -				(u64)pm8001_ha->io_mem[logicalBar].memvirtaddr,
> +				(void __iomem *)
> +				pm8001_ha->io_mem[logicalBar].memvirtaddr,
>  				pm8001_ha->io_mem[logicalBar].memsize));
>  		} else {
>  			pm8001_ha->io_mem[logicalBar].membase	= 0;
> 


-- 
~Randy