From: Randy Dunlap <rdunlap@infradead.org>
To: Anton Blanchard <anton@samba.org>
Cc: linux-scsi@vger.kernel.org, james.smart@emulex.com,
JBottomley@parallels.com
Subject: Re: Why does lpfc select GENERIC_CSUM?
Date: Wed, 07 Aug 2013 15:25:19 -0700 [thread overview]
Message-ID: <5202C94F.5070701@infradead.org> (raw)
In-Reply-To: <20130805202017.651b6cfd@kryten>
On 08/05/13 03:20, Anton Blanchard wrote:
>
> Hi Randy,
>
> commit 6a7252fd ([SCSI] lpfc: fix up Kconfig dependencies) added a
> select of GENERIC_CSUM. This seems strange to me - it's an architecture
> specific detail if the checksum routines are implemented in assembly or
> if they pull in lib/checksum.c.
>
> The networking code doesn't select GENERIC_CSUM, so I'm not sure why
> the lpfc driver needs to. Was there a real issue we hit here?
>
> Regards,
> Anton
>
Hi Anton,
I reported:
"""
on i386:
# CONFIG_CRC_T10DIF is not set
drivers/built-in.o: In function `lpfc_bg_crc':
(.text+0x3cb3c9): undefined reference to `crc_t10dif'
"""
and then James Bottomley provided the patch.
I don't know why he added GENERIC_CSUM to it.
--
~Randy
next prev parent reply other threads:[~2013-08-07 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 10:20 Why does lpfc select GENERIC_CSUM? Anton Blanchard
2013-08-07 22:25 ` Randy Dunlap [this message]
2013-08-08 7:47 ` [SCSI] lpfc: Don't force CONFIG_GENERIC_CSUM on Anton Blanchard
2013-08-08 15:01 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5202C94F.5070701@infradead.org \
--to=rdunlap@infradead.org \
--cc=JBottomley@parallels.com \
--cc=anton@samba.org \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).