From: Jack Wang <xjtuwjp@gmail.com>
To: James Bottomley <jbottomley@parallels.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-scsi@vger.kernel.org, AnandKumar.Santhanam@pmcs.com,
lindar_liu@usish.com, Sangeetha.Gnanasekaran@pmcs.com
Subject: Re: [PATCHv2] pm80xx: fix Adaptec 71605H hang
Date: Wed, 21 Aug 2013 14:53:02 +0200 [thread overview]
Message-ID: <5214B82E.5090208@gmail.com> (raw)
In-Reply-To: <51F92B0C.70804@gmail.com>
On 07/31/2013 05:19 PM, Jack Wang wrote:
> On 07/26/2013 06:43 PM, Hans Verkuil wrote:
>> The IO command size is 128 bytes for these new controllers as opposed to 64
>> for the old 8001 controller.
>>
>> The Adaptec out-of-tree driver did this correctly. After comparing the two
>> this turned out to be the crucial difference.
>>
>> So don't hardcode the IO command size, instead use pm8001_ha->iomb_size as
>> that is the correct value for both old and new controllers.
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>> Cc: stable@vger.kernel.org # for v3.10 and up
> snip
>
> Thanks Hans.
> Looks good now.
>
> Acked-by: Jack Wang <xjtuwjp@gmail.com>
>
> James,
>
> Could you consider to include this fix into your fixes tree, without
> this fix new Adaptec controller support is broken, sorry for that.
>
>
> Jack
>
Hi, James,
Could you include this patch, or you need we resend?
KR
Jack
prev parent reply other threads:[~2013-08-21 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 16:43 [PATCHv2] pm80xx: fix Adaptec 71605H hang Hans Verkuil
2013-07-27 2:51 ` Anand Kumar Santhanam
2013-07-31 15:19 ` Jack Wang
2013-08-21 12:53 ` Jack Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214B82E.5090208@gmail.com \
--to=xjtuwjp@gmail.com \
--cc=AnandKumar.Santhanam@pmcs.com \
--cc=Sangeetha.Gnanasekaran@pmcs.com \
--cc=hverkuil@xs4all.nl \
--cc=jbottomley@parallels.com \
--cc=lindar_liu@usish.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).