From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Wang Subject: Re: [PATCHv2] pm80xx: fix Adaptec 71605H hang Date: Wed, 21 Aug 2013 14:53:02 +0200 Message-ID: <5214B82E.5090208@gmail.com> References: <51F2A741.1020702@xs4all.nl> <51F92B0C.70804@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f54.google.com ([209.85.214.54]:57827 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544Ab3HUMwv (ORCPT ); Wed, 21 Aug 2013 08:52:51 -0400 Received: by mail-bk0-f54.google.com with SMTP id mz12so149371bkb.41 for ; Wed, 21 Aug 2013 05:52:50 -0700 (PDT) In-Reply-To: <51F92B0C.70804@gmail.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Hans Verkuil , linux-scsi@vger.kernel.org, AnandKumar.Santhanam@pmcs.com, lindar_liu@usish.com, Sangeetha.Gnanasekaran@pmcs.com On 07/31/2013 05:19 PM, Jack Wang wrote: > On 07/26/2013 06:43 PM, Hans Verkuil wrote: >> The IO command size is 128 bytes for these new controllers as opposed to 64 >> for the old 8001 controller. >> >> The Adaptec out-of-tree driver did this correctly. After comparing the two >> this turned out to be the crucial difference. >> >> So don't hardcode the IO command size, instead use pm8001_ha->iomb_size as >> that is the correct value for both old and new controllers. >> >> Signed-off-by: Hans Verkuil >> Cc: stable@vger.kernel.org # for v3.10 and up > snip > > Thanks Hans. > Looks good now. > > Acked-by: Jack Wang > > James, > > Could you consider to include this fix into your fixes tree, without > this fix new Adaptec controller support is broken, sorry for that. > > > Jack > Hi, James, Could you include this patch, or you need we resend? KR Jack