From: Jeremy Linton <jlinton@tributary.com>
To: "james.smart@emulex.com" <james.smart@emulex.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 17/18] lpfc 8.3.42: Fixed issue of task management commands having a fixed timeout
Date: Fri, 6 Sep 2013 13:38:29 -0500 [thread overview]
Message-ID: <522A2125.9040406@tributary.com> (raw)
In-Reply-To: <1378484566.14051.36.camel@myfc17>
On 9/6/2013 11:22 AM, James Smart wrote:
> Fixed issue of task management commands having a fixed timeout
I'm surprised about this change, since it appears a number of issues in the
send_taskmgmt() still exist that keep it from handling task management
failures correctly. It also continues to have a number of smaller issues like
for example dead code of the form
if (status != IOCB_STATUS)
else if (status == IOCB_BUSY)
else
See patch:
"lpfc should check return status for task mgmt IOCB"
http://marc.info/?l=linux-scsi&m=136242124409687
next prev parent reply other threads:[~2013-09-06 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 16:22 [PATCH 17/18] lpfc 8.3.42: Fixed issue of task management commands having a fixed timeout James Smart
2013-09-06 18:38 ` Jeremy Linton [this message]
2013-09-08 13:59 ` James Smart
2013-09-09 14:43 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522A2125.9040406@tributary.com \
--to=jlinton@tributary.com \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).