* [PATCH] dm mpath: do not fail path on -ENOSPC
@ 2013-09-13 5:54 Jun'ichi Nomura
2013-09-13 5:58 ` Hannes Reinecke
0 siblings, 1 reply; 2+ messages in thread
From: Jun'ichi Nomura @ 2013-09-13 5:54 UTC (permalink / raw)
To: device-mapper development, Hannes Reinecke; +Cc: linux-scsi
Since ENOSPC is a target-side error, dm-mpath should just pass the error
information to upper layer instead of retrying itself with path failover.
Otherwise it will end up failing all paths down while path checkers find
all paths ok.
ENOSPC can now be returned from SCSI device after commit a9d6ceb8
("[SCSI] return ENOSPC on thin provisioning failure").
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Hannes Reinecke <hare@suse.de>
---
drivers/md/dm-mpath.c | 1 +
1 file changed, 1 insertion(+)
The patch is not actually tested as I don't have such a storage at my hand.
Hannes, please let me know if you didn't change noretry_error() intentionally.
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index b759a12..075747e 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -1268,6 +1268,7 @@ static int noretry_error(int error)
case -EREMOTEIO:
case -EILSEQ:
case -ENODATA:
+ case -ENOSPC:
return 1;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dm mpath: do not fail path on -ENOSPC
2013-09-13 5:54 [PATCH] dm mpath: do not fail path on -ENOSPC Jun'ichi Nomura
@ 2013-09-13 5:58 ` Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2013-09-13 5:58 UTC (permalink / raw)
To: Jun'ichi Nomura; +Cc: device-mapper development, linux-scsi
On 09/13/2013 07:54 AM, Jun'ichi Nomura wrote:
> Since ENOSPC is a target-side error, dm-mpath should just pass the error
> information to upper layer instead of retrying itself with path failover.
> Otherwise it will end up failing all paths down while path checkers find
> all paths ok.
>
> ENOSPC can now be returned from SCSI device after commit a9d6ceb8
> ("[SCSI] return ENOSPC on thin provisioning failure").
>
> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
> Cc: Hannes Reinecke <hare@suse.de>
> ---
> drivers/md/dm-mpath.c | 1 +
> 1 file changed, 1 insertion(+)
>
> The patch is not actually tested as I don't have such a storage at my hand.
> Hannes, please let me know if you didn't change noretry_error() intentionally.
>
No, you are correct. I've missed this bit when sending out the
enhanced I/O errors patch.
Acked-by: Hannes Reinecke <hare@suse.de>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index b759a12..075747e 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1268,6 +1268,7 @@ static int noretry_error(int error)
> case -EREMOTEIO:
> case -EILSEQ:
> case -ENODATA:
> + case -ENOSPC:
> return 1;
> }
>
>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-13 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 5:54 [PATCH] dm mpath: do not fail path on -ENOSPC Jun'ichi Nomura
2013-09-13 5:58 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).