From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernd Schubert Subject: Re: Drivers: scsi: FLUSH timeout Date: Tue, 24 Sep 2013 15:10:53 +0200 Message-ID: <52418F5D.8030805@fastmail.fm> References: <1379705547-15028-1-git-send-email-kys@microsoft.com> <20130920203222.GA14306@kroah.com> <524180B7.7090307@gmail.com> <3413dbd7fa254fd380a84fe6d9cd87e1@SN2PR03MB061.namprd03.prod.outlook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailgw1.uni-kl.de ([131.246.120.220]:39315 "EHLO mailgw1.uni-kl.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752720Ab3IXNLH (ORCPT ); Tue, 24 Sep 2013 09:11:07 -0400 In-Reply-To: <3413dbd7fa254fd380a84fe6d9cd87e1@SN2PR03MB061.namprd03.prod.outlook.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: KY Srinivasan , Jack Wang Cc: Greg KH , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "ohering@suse.com" , "jbottomley@parallels.com" , "hch@infradead.org" , "linux-scsi@vger.kernel.org" , Mike Christie On 09/24/2013 02:35 PM, KY Srinivasan wrote: > > >> -----Original Message----- >> From: Jack Wang [mailto:xjtuwjp@gmail.com] >> Sent: Tuesday, September 24, 2013 5:08 AM >> To: KY Srinivasan >> Cc: Greg KH; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; >> ohering@suse.com; jbottomley@parallels.com; hch@infradead.org; linux- >> scsi@vger.kernel.org; Mike Christie >> Subject: Re: Drivers: scsi: FLUSH timeout >> >> On 09/21/2013 07:24 AM, KY Srinivasan wrote: >>> >>> >>>> -----Original Message----- >>>> From: Greg KH [mailto:gregkh@linuxfoundation.org] >>>> Sent: Friday, September 20, 2013 1:32 PM >>>> To: KY Srinivasan >>>> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; >>>> ohering@suse.com; jbottomley@parallels.com; hch@infradead.org; linux- >>>> scsi@vger.kernel.org >>>> Subject: Re: Drivers: scsi: FLUSH timeout >>>> >>>> On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: >>>>> The SD_FLUSH_TIMEOUT value is currently hardcoded. >>>> >>>> Hardcoded where? Please, more context. >>> >>> This is defined in scsi/sd.h: >>> >>> #define SD_FLUSH_TIMEOUT (60 * HZ) >>>> >>>>> On our cloud, we sometimes hit this timeout. I was wondering if we >>>>> could make this a module parameter. If this is acceptable, I can send >>>>> you a patch for this. >>>> >>>> A module parameter don't make sense for a per-device value, does it? >>> Currently, the 60 second timeout is applied across devices. Ideally, I want to be >>> able to control the FLUSH TIMEOUT as we currently do I/O timeout. If this is >>> acceptable, I can work on a patch for that as well. >>> >>> Regards, >>> >>> K. Y >>>> >>>> greg k-h >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> Hi, >> >> Back to 2010, Mike(cc-ed) try to add a flush time out interface, similar >> to what you want here, no idea why it's just ignored? >> http://www.spinics.net/lists/linux-scsi/msg45017.html > > Thanks Jack. Mike, do you know what the concerns were as to why this > patch was not accepted? > See also this discussion: http://marc.info/?l=linux-scsi&m=127167679221319&w=2 And retries have been added by commit c213e1407be6b04b144794399a91472e0ef92aec Cheers, Bernd