From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Wang Subject: Re: [PATCH V2 01/10] pm80xx: Device id changes to support series 8 controllers. Date: Thu, 26 Sep 2013 08:39:45 +0200 Message-ID: <5243D6B1.1060906@gmail.com> References: <5243C5AD.3030607@pmc-sierra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com ([74.125.83.42]:56266 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755Ab3IZGjh (ORCPT ); Thu, 26 Sep 2013 02:39:37 -0400 Received: by mail-ee0-f42.google.com with SMTP id b45so296294eek.1 for ; Wed, 25 Sep 2013 23:39:35 -0700 (PDT) In-Reply-To: <5243C5AD.3030607@pmc-sierra.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Anand Cc: linux-scsi@vger.kernel.org, Sangeetha.Gnanasekaran@pmcs.com, Nikith.Ganigarakoppal@pmcs.com, Viswas.G@pmcs.com snip > */ > payload.ase_sh_lm_slr_phyid = cpu_to_le32(SPINHOLD_DISABLE | > LINKMODE_AUTO | LINKRATE_15 | > - LINKRATE_30 | LINKRATE_60 | phy_id); > + LINKRATE_30 | LINKRATE_60 | LINKRATE_120 | phy_id); Is it safe to set 12g linkrate support also on 6g, if so, then : Reviewed-by: Jack Wang > /* SSC Disable and SAS Analog ST configuration */ > /** > payload.ase_sh_lm_slr_phyid = > diff --git a/drivers/scsi/pm8001/pm80xx_hwi.h b/drivers/scsi/pm8001/pm80xx_hwi.h > index 2b760ba..9a9116d 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.h > +++ b/drivers/scsi/pm8001/pm80xx_hwi.h > @@ -168,6 +168,7 @@ > #define LINKRATE_15 (0x01 << 8) > #define LINKRATE_30 (0x02 << 8) > #define LINKRATE_60 (0x06 << 8) > +#define LINKRATE_120 (0x08 << 8) > > /* Thermal related */ > #define THERMAL_ENABLE 0x1 > @@ -1223,10 +1224,10 @@ typedef struct SASProtocolTimerConfig SASProtocolTimerConfig_t; > > /* MSGU CONFIGURATION TABLE*/ > > -#define SPCv_MSGU_CFG_TABLE_UPDATE 0x01 > -#define SPCv_MSGU_CFG_TABLE_RESET 0x02 > -#define SPCv_MSGU_CFG_TABLE_FREEZE 0x04 > -#define SPCv_MSGU_CFG_TABLE_UNFREEZE 0x08 > +#define SPCv_MSGU_CFG_TABLE_UPDATE 0x001 > +#define SPCv_MSGU_CFG_TABLE_RESET 0x002 > +#define SPCv_MSGU_CFG_TABLE_FREEZE 0x004 > +#define SPCv_MSGU_CFG_TABLE_UNFREEZE 0x008 > #define MSGU_IBDB_SET 0x00 > #define MSGU_HOST_INT_STATUS 0x08 > #define MSGU_HOST_INT_MASK 0x0C >