From: Jack Wang <xjtuwjp@gmail.com>
To: Anand <anandkumar_santhanam@pmc-sierra.com>
Cc: linux-scsi@vger.kernel.org, Sangeetha.Gnanasekaran@pmcs.com,
Nikith.Ganigarakoppal@pmcs.com, Viswas.G@pmcs.com
Subject: Re: [PATCH V2 02/10] pm80xx: IButton feature support for motherboard controllers.
Date: Thu, 26 Sep 2013 08:42:00 +0200 [thread overview]
Message-ID: <5243D738.2070207@gmail.com> (raw)
In-Reply-To: <5243C614.4080207@pmc-sierra.com>
On 09/26/2013 07:28 AM, Anand wrote:
> From d6b5e5d88f424b334c9b9c241f988b9eec1a70c7 Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>
> Date: Tue, 17 Sep 2013 14:32:20 +0530
> Subject: [PATCH V2 02/10] pm80xx: IButton feature support for motherboard controllers.
>
> IButton security feature support for motherboard controllers.
>
> Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com>
>
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 22 +++++++++++++++++++++-
> 1 files changed, 21 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 8efac42..912dfec 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -967,6 +967,7 @@ pm80xx_chip_soft_rst(struct pm8001_hba_info *pm8001_ha)
> {
> u32 regval;
> u32 bootloader_state;
> + u32 ibutton0, ibutton1;
>
> /* Check if MPI is in ready state to reset */
> if (mpi_uninit_check(pm8001_ha) != 0) {
> @@ -1025,7 +1026,26 @@ pm80xx_chip_soft_rst(struct pm8001_hba_info *pm8001_ha)
> if (-1 == check_fw_ready(pm8001_ha)) {
> PM8001_FAIL_DBG(pm8001_ha,
> pm8001_printk("Firmware is not ready!\n"));
> - return -EBUSY;
> + /* check iButton feature support for motherboard controller */
> + if (pm8001_ha->pdev->subsystem_vendor !=
> + PCI_VENDOR_ID_ADAPTEC2) {
> + ibutton0 = pm8001_cr32(pm8001_ha, 0,
> + MSGU_HOST_SCRATCH_PAD_6);
> + ibutton1 = pm8001_cr32(pm8001_ha, 0,
> + MSGU_HOST_SCRATCH_PAD_7);
> + if (!ibutton0 && !ibutton1) {
> + PM8001_FAIL_DBG(pm8001_ha,
> + pm8001_printk("iButton Feature is"
> + " not Available!!!\n"));
> + return -EBUSY;
> + }
> + if (ibutton0 == 0xdeadbeef && ibutton1 == 0xdeadbeef) {
> + PM8001_FAIL_DBG(pm8001_ha,
> + pm8001_printk("CRC Check for iButton"
> + " Feature Failed!!!\n"));
> + return -EBUSY;
> + }
> + }
> }
> PM8001_INIT_DBG(pm8001_ha,
> pm8001_printk("SPCv soft reset Complete\n"));
>
prev parent reply other threads:[~2013-09-26 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 5:28 [PATCH V2 02/10] pm80xx: IButton feature support for motherboard controllers Anand
2013-09-26 6:42 ` Jack Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243D738.2070207@gmail.com \
--to=xjtuwjp@gmail.com \
--cc=Nikith.Ganigarakoppal@pmcs.com \
--cc=Sangeetha.Gnanasekaran@pmcs.com \
--cc=Viswas.G@pmcs.com \
--cc=anandkumar_santhanam@pmc-sierra.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).