From: Jack Wang <xjtuwjp@gmail.com>
To: Anand <anandkumar_santhanam@pmc-sierra.com>
Cc: linux-scsi@vger.kernel.org, Sangeetha.Gnanasekaran@pmcs.com,
Nikith.Ganigarakoppal@pmcs.com, Viswas.G@pmcs.com
Subject: Re: [PATCH V2 03/10] pm80xx: Indirect SMP request fix
Date: Thu, 26 Sep 2013 08:48:15 +0200 [thread overview]
Message-ID: <5243D8AF.7070802@gmail.com> (raw)
In-Reply-To: <5243C658.5000406@pmc-sierra.com>
On 09/26/2013 07:30 AM, Anand wrote:
> From adf0140b2a05f51f6cb9ccefd0f82f3905b0692b Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>
> Date: Tue, 17 Sep 2013 14:37:14 +0530
> Subject: [PATCH V2 03/10] pm80xx: Indirect SMP request fix.
>
> Fix for indirect data transfer mode in case of SMP request.
>
> Signed-off-by: Anandkumar.Santhanam@pmcs.com
>
Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com>
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 912dfec..99cec5f 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -3512,8 +3512,6 @@ static int pm80xx_chip_smp_req(struct pm8001_hba_info *pm8001_ha,
> else
> pm8001_ha->smp_exp_mode = SMP_INDIRECT;
>
> - /* DIRECT MODE support only in spcv/ve */
> - pm8001_ha->smp_exp_mode = SMP_DIRECT;
>
> tmp_addr = cpu_to_le64((u64)sg_dma_address(&task->smp_task.smp_req));
> preq_dma_addr = (char *)phys_to_virt(tmp_addr);
> @@ -3529,7 +3527,7 @@ static int pm80xx_chip_smp_req(struct pm8001_hba_info *pm8001_ha,
> /* exclude top 4 bytes for SMP req header */
> smp_cmd.long_smp_req.long_req_addr =
> cpu_to_le64((u64)sg_dma_address
> - (&task->smp_task.smp_req) - 4);
> + (&task->smp_task.smp_req) + 4);
> /* exclude 4 bytes for SMP req header and CRC */
> smp_cmd.long_smp_req.long_req_size =
> cpu_to_le32((u32)sg_dma_len(&task->smp_task.smp_req)-8);
>
prev parent reply other threads:[~2013-09-26 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 5:30 [PATCH V2 03/10] pm80xx: Indirect SMP request fix Anand
2013-09-26 6:48 ` Jack Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243D8AF.7070802@gmail.com \
--to=xjtuwjp@gmail.com \
--cc=Nikith.Ganigarakoppal@pmcs.com \
--cc=Sangeetha.Gnanasekaran@pmcs.com \
--cc=Viswas.G@pmcs.com \
--cc=anandkumar_santhanam@pmc-sierra.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).