From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Wang Subject: Re: [PATCH V2 03/10] pm80xx: Indirect SMP request fix Date: Thu, 26 Sep 2013 08:48:15 +0200 Message-ID: <5243D8AF.7070802@gmail.com> References: <5243C658.5000406@pmc-sierra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f175.google.com ([209.85.215.175]:53216 "EHLO mail-ea0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395Ab3IZGsG (ORCPT ); Thu, 26 Sep 2013 02:48:06 -0400 Received: by mail-ea0-f175.google.com with SMTP id m14so295082eaj.20 for ; Wed, 25 Sep 2013 23:48:05 -0700 (PDT) In-Reply-To: <5243C658.5000406@pmc-sierra.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Anand Cc: linux-scsi@vger.kernel.org, Sangeetha.Gnanasekaran@pmcs.com, Nikith.Ganigarakoppal@pmcs.com, Viswas.G@pmcs.com On 09/26/2013 07:30 AM, Anand wrote: > From adf0140b2a05f51f6cb9ccefd0f82f3905b0692b Mon Sep 17 00:00:00 2001 > From: Anand Kumar Santhanam > Date: Tue, 17 Sep 2013 14:37:14 +0530 > Subject: [PATCH V2 03/10] pm80xx: Indirect SMP request fix. > > Fix for indirect data transfer mode in case of SMP request. > > Signed-off-by: Anandkumar.Santhanam@pmcs.com > Reviewed-by: Jack Wang > --- > drivers/scsi/pm8001/pm80xx_hwi.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c > index 912dfec..99cec5f 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.c > +++ b/drivers/scsi/pm8001/pm80xx_hwi.c > @@ -3512,8 +3512,6 @@ static int pm80xx_chip_smp_req(struct pm8001_hba_info *pm8001_ha, > else > pm8001_ha->smp_exp_mode = SMP_INDIRECT; > > - /* DIRECT MODE support only in spcv/ve */ > - pm8001_ha->smp_exp_mode = SMP_DIRECT; > > tmp_addr = cpu_to_le64((u64)sg_dma_address(&task->smp_task.smp_req)); > preq_dma_addr = (char *)phys_to_virt(tmp_addr); > @@ -3529,7 +3527,7 @@ static int pm80xx_chip_smp_req(struct pm8001_hba_info *pm8001_ha, > /* exclude top 4 bytes for SMP req header */ > smp_cmd.long_smp_req.long_req_addr = > cpu_to_le64((u64)sg_dma_address > - (&task->smp_task.smp_req) - 4); > + (&task->smp_task.smp_req) + 4); > /* exclude 4 bytes for SMP req header and CRC */ > smp_cmd.long_smp_req.long_req_size = > cpu_to_le32((u32)sg_dma_len(&task->smp_task.smp_req)-8); >