From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: Ren Mingxin <renmx@cn.fujitsu.com>,
linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
Joern Engel <joern@logfs.org>,
James Smart <james.smart@emulex.com>,
Bart Van Assche <bvanassche@acm.org>,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH 2/3] scsi: improved eh timeout handler
Date: Wed, 02 Oct 2013 18:24:12 +0200 [thread overview]
Message-ID: <524C48AC.2010901@suse.de> (raw)
In-Reply-To: <523C0054.9010908@cn.fujitsu.com>
On 09/20/2013 09:59 AM, Ren Mingxin wrote:
> Hi, Hannes:
>
> On 09/02/2013 07:58 PM, Hannes Reinecke wrote:
>> +scmd_eh_abort_handler(struct work_struct *work)
>> +{
>> + struct scsi_cmnd *scmd =
>> + container_of(work, struct scsi_cmnd, abort_work.work);
>> + struct scsi_device *sdev = scmd->device;
>> + unsigned long flags;
>> + int rtn;
>> +
>> + spin_lock_irqsave(sdev->host->host_lock, flags);
>> + if (scsi_host_eh_past_deadline(sdev->host)) {
>> + spin_unlock_irqrestore(sdev->host->host_lock, flags);
>> + SCSI_LOG_ERROR_RECOVERY(3,
>> + scmd_printk(KERN_INFO, scmd,
>> + "scmd %p eh timeout, not aborting\n", scmd));
>> + } else {
>> + spin_unlock_irqrestore(sdev->host->host_lock, flags);
>> + SCSI_LOG_ERROR_RECOVERY(3,
>> + scmd_printk(KERN_INFO, scmd,
>> + "aborting command %p\n", scmd));
>> + rtn = scsi_try_to_abort_cmd(sdev->host->hostt, scmd);
>> + if (rtn == SUCCESS) {
>> + scmd->result |= DID_TIME_OUT<< 16;
>> + if (!scsi_noretry_cmd(scmd)&&
>> + (++scmd->retries<= scmd->allowed)) {
>
> I think scsi_host_eh_past_deadline() should be checked here like:
>
> - if (!scsi_noretry_cmd(scmd)&&
> + if (!scsi_host_eh_past_deadline(sdev->host)&&
> + !scsi_noretry_cmd(scmd)&&
>
> According to my test, once retry requires 30 seconds. If eh_deadline
> is reached, we can stop EH here without waiting for long term
> retrying.
>
Hmm. We could. Providing the eh_deadline patches are going in.
James, should I resend the patchset?
Does it even have a chance of getting in?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-02 15:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 11:58 [PATCHv6 0/3] New EH command timeout handler Hannes Reinecke
2013-09-02 11:58 ` [PATCH 1/3] scsi: Fix erratic device offline during EH Hannes Reinecke
2013-09-11 14:36 ` Jeremy Linton
2013-10-16 19:22 ` James Bottomley
2013-10-23 8:58 ` Martin K. Petersen
2013-10-23 9:27 ` Hannes Reinecke
2013-09-02 11:58 ` [PATCH 2/3] scsi: improved eh timeout handler Hannes Reinecke
2013-09-11 9:16 ` Ren Mingxin
2013-09-12 20:49 ` Hannes Reinecke
2013-09-20 7:59 ` Ren Mingxin
2013-10-02 16:24 ` Hannes Reinecke [this message]
2013-10-09 7:43 ` [PATCH] scsi: Set the minimum valid value of 'eh_deadline' as 0 Ren Mingxin
2013-10-09 9:38 ` Hannes Reinecke
2013-10-09 12:28 ` Ewan Milne
2013-10-10 8:46 ` Ren Mingxin
2013-09-02 11:58 ` [PATCH 3/3] scsi_error: Update documentation Hannes Reinecke
2013-10-02 7:25 ` [PATCHv6 0/3] New EH command timeout handler Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2013-10-31 13:02 [PATCHv8 " Hannes Reinecke
2013-10-31 13:02 ` [PATCH 2/3] scsi: improved eh " Hannes Reinecke
2013-10-31 15:49 ` Christoph Hellwig
2013-11-04 13:36 ` Hannes Reinecke
2013-11-04 14:25 ` James Bottomley
2013-11-04 14:46 ` Hannes Reinecke
2013-11-04 14:50 ` James Bottomley
2013-11-04 15:43 ` Hannes Reinecke
2013-11-05 1:07 ` James Bottomley
2013-11-01 6:10 ` Ren Mingxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524C48AC.2010901@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).