public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	James Smart <james.smart@emulex.com>,
	Andrew Vasquez <andrew.vasquez@qlogic.com>
Subject: Re: Is there any plan to support 64bit lun in mainline?
Date: Tue, 15 Oct 2013 08:01:14 +0200	[thread overview]
Message-ID: <525CDA2A.2060308@suse.de> (raw)
In-Reply-To: <1381775449.3752.9.camel@dabdike.lan>

On 10/14/2013 08:30 PM, James Bottomley wrote:
> On Mon, 2013-10-14 at 12:32 +0200, Hannes Reinecke wrote:
[ .. ]
>>
>> However, there are two other patchsets pending (EH Deadline and
>> asynchronous command aborts), both of which have been tested
>> thoroughly _and_ have acked-by from various other parties.
>> None of these patchset had received any feedback from James
>> Bottomley, let alone any indication if or when they'll be merged.
>>
>> So I stopped sending further patchsets, sensing some communication
>> breakdown on the line.
> 
> There's no communications breakdown, I've just been very busy.  EH
> deadline looks OK, but let me look again to make sure.  Async aborts I'm
> not necessarily keen on because I know a lot of devices where aborting
> just confuses the firmware more, so I think skipping aborts and moving
> to LUN reset might be a better form of acceleration.
> 

Hmm. I've made exactly the opposite experience with FC devices.
A faulty SFP or wiring might cause the occasional frame drop, which
will be happily corrected with an ABTS.
And HBAs like lpfc or qla2xxx even have a fast command abort built
into the firmware, where the firmware will not even wait for a
command abort to hit the wire but rather just disable the exchange
internally and return.
_Not_ sending an abort but rather escalating directly to LUN reset
will only make matters worse here.
Plus a LUN reset won't be able to fix anything here.

But sure, if there are some devices which are confused by aborts,
sure we should be doing something about it.
Just out of curiosity, which devices are we talking about?

I would very much prefer to have inlined command aborts at least for
FC, as it has proven to be really beneficial there.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-10-15  6:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  6:35 Is there any plan to support 64bit lun in mainline? Wangshen (C)
2013-10-14 10:32 ` Hannes Reinecke
2013-10-14 15:29   ` Christoph Hellwig
2013-10-20 16:20     ` Douglas Gilbert
2013-10-14 18:30   ` James Bottomley
2013-10-15  6:01     ` Hannes Reinecke [this message]
2013-10-15 14:58       ` James Bottomley
2013-10-16  4:11       ` Vladislav Bolkhovitin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525CDA2A.2060308@suse.de \
    --to=hare@suse.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=hch@infradead.org \
    --cc=james.smart@emulex.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox