linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2][RESEND] scsi_dh_alua: ALUA check sense should retry device internal reset unit attention
@ 2013-10-15 15:52 Stewart, Sean
  2013-10-16  5:47 ` Hannes Reinecke
  0 siblings, 1 reply; 2+ messages in thread
From: Stewart, Sean @ 2013-10-15 15:52 UTC (permalink / raw)
  To: linux-scsi; +Cc: James Bottomley, Hannes Reinecke

When the scsi_dh_alua handler issues an RTPG during initialization, if it gets 0x06/0x29/0x04 as the sense,
it will fail to attach the handler.  NetApp E-Series returns 0x29/0x00 for power on, and 0x29/0x04 for
conditions that cause the controller to reboot again.  These conditions should be treated identically within
the handler.

Signed-off-by: Sean Stewart <Sean.Stewart@netapp.com>
---
 drivers/scsi/device_handler/scsi_dh_alua.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 68adb89..78205cc 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -481,6 +481,11 @@ static int alua_check_sense(struct scsi_device *sdev,
 			 * Power On, Reset, or Bus Device Reset, just retry.
 			 */
 			return ADD_TO_MLQUEUE;
+		if (sense_hdr->asc == 0x29 && sense_hdr->ascq == 0x04)
+			/*
+			 * Device internal reset
+			 */
+			return ADD_TO_MLQUEUE;
 		if (sense_hdr->asc == 0x2a && sense_hdr->ascq == 0x01)
 			/*
 			 * Mode Parameters Changed
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2][RESEND] scsi_dh_alua: ALUA check sense should retry device internal reset unit attention
  2013-10-15 15:52 [PATCH 1/2][RESEND] scsi_dh_alua: ALUA check sense should retry device internal reset unit attention Stewart, Sean
@ 2013-10-16  5:47 ` Hannes Reinecke
  0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2013-10-16  5:47 UTC (permalink / raw)
  To: Stewart, Sean; +Cc: linux-scsi, James Bottomley

On 10/15/2013 05:52 PM, Stewart, Sean wrote:
> When the scsi_dh_alua handler issues an RTPG during initialization, if it gets 0x06/0x29/0x04 as the sense,
> it will fail to attach the handler.  NetApp E-Series returns 0x29/0x00 for power on, and 0x29/0x04 for
> conditions that cause the controller to reboot again.  These conditions should be treated identically within
> the handler.
> 
> Signed-off-by: Sean Stewart <Sean.Stewart@netapp.com>
Acked-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-16  5:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15 15:52 [PATCH 1/2][RESEND] scsi_dh_alua: ALUA check sense should retry device internal reset unit attention Stewart, Sean
2013-10-16  5:47 ` Hannes Reinecke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).