Re: [PATCH] [SCSI] sg: late O_EXCL fix for lk 3.12-rc

Bart Van Assche
2013-10-20T17:31:58Z

On 10/20/13 18:09, Douglas Gilbert wrote:
> Given that lk 3.12.0 release is not far away, the safest path
> may still be to revert Vaughan Cao's patch. I'll leave that
> decision to the maintainers.

Hello Doug,

Thanks for looking into this. But I would appreciate it if you could
address the whitespace errors reported by checkpatch:

ERROR: space prohibited after that '!' (ctx:BxW)
#24: FILE: drivers/scsi/sg.c:241:
+ (excl_case ? (! sdp->exclude) : sfds_list_empty(sdp))));
^

ERROR: space prohibited after that '!' (ctx:BxW)
#55: FILE: drivers/scsi/sg.c:289:
+ if (! alone) {
^

ERROR: code indent should use tabs where possible
#59: FILE: drivers/scsi/sg.c:292:
+ }$

WARNING: please, no spaces at the start of a line
#59: FILE: drivers/scsi/sg.c:292:
+ }$

ERROR: space prohibited after that '!' (ctx:BxW)
#73: FILE: drivers/scsi/sg.c:301:
+ while (! alone) {
^

WARNING: suspect code indent for conditional statements (8, 12)
#144: FILE: drivers/scsi/sg.c:375:
+ if (excl || sfds_list_empty(sdp))
+ wake_up_interruptible(&sdp->open_wait);

Thanks,

Bart.