From: Douglas Gilbert <dgilbert@interlog.com>
To: Akinobu Mita <akinobu.mita@gmail.com>, linux-scsi@vger.kernel.org
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi_debug: simplify creation and destruction of driver attribute files
Date: Sun, 03 Nov 2013 14:10:41 -0500 [thread overview]
Message-ID: <52769FB1.7010409@interlog.com> (raw)
In-Reply-To: <1381758484-26083-1-git-send-email-akinobu.mita@gmail.com>
On 13-10-14 09:48 AM, Akinobu Mita wrote:
> Instead of repeatedly calling driver_create_file() to create driver
> attribute files, This achieves the same thing by constructing an array
> of driver_attribute and setting it to bus_type->drv_groups.
>
> This change simplifies both creation and destruction of the attribute
> files, and also removes sparse warning caused by driver_attributes which
> are unnecessarily declared as global.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
> Cc: Douglas Gilbert <dgilbert@interlog.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org
<snip>
prev parent reply other threads:[~2013-11-03 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 13:48 [PATCH] scsi_debug: simplify creation and destruction of driver attribute files Akinobu Mita
2013-11-03 19:10 ` Douglas Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52769FB1.7010409@interlog.com \
--to=dgilbert@interlog.com \
--cc=JBottomley@parallels.com \
--cc=akinobu.mita@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).