Re: [PATCH 1/2] libata: use sleep instead of standby command

Aaron Lu
2013-11-05T02:23:50Z

+linux-ide

On 11/05/2013 08:52 AM, Phillip Susi wrote:
> The ATA SLEEP mode saves some more power than SUSPEND, and
> has basically the same recovery time, so use it instead.

I suppose this is mainly for runtime PM? Since for system
suspend/hibernation, the disk and its controller will be powered off
anyway.

Best regards,
Aaron

>
> Signed-off-by: Phillip Susi <psusi@ubuntu.com>
> ---
> drivers/ata/libata-scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 97a0cef..79b75fd 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1362,8 +1362,8 @@ static unsigned int ata_scsi_start_stop_xlat(struct ata_queued_cmd *qc)
> system_entering_hibernation())
> goto skip;
>
> - /* Issue ATA STANDBY IMMEDIATE command */
> - tf->command = ATA_CMD_STANDBYNOW1;
> + /* Issue ATA SLEEP command */
> + tf->command = ATA_CMD_SLEEP;
> }
>
> /*
>