From: Luben Tuikov <ltuikov@yahoo.com>
To: James Bottomley <James.Bottomley@suse.de>,
Alan Stern <stern@rowland.harvard.edu>
Cc: Richard Senior <richard@r-senior.demon.co.uk>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] sd: Fix regression in sd_read_cache_type
Date: Wed, 23 Mar 2011 09:44:34 -0700 (PDT) [thread overview]
Message-ID: <529298.55791.qm@web31812.mail.mud.yahoo.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1103231146460.2211-100000@iolanthe.rowland.org>
--- On Wed, 3/23/11, Alan Stern <stern@rowland.harvard.edu> wrote:
>
> Reverting the original patch for now is fine with me.
You mean my patch? This commit: 24d720b726c1a85f1962831ac30ad4d2ef8276b1.
> As for the next
> merge window, let me submit a more bullet-proof version of
> the second
> patch.
How can you submit a "more bullet-proof" version of the second patch without the "first", which would be my topic patch I assume? This
one: 24d720b726c1a85f1962831ac30ad4d2ef8276b1.
Does this mean you'll resubmit my topic patch as your own and roll your minor patch with it?
> It's possible that some wierd USB device will report that
> more than 192
> bytes of mode-sense data is available and then fail when
> the host asks
> for the reported amount. You'd think no device could
> be that stupid,
If by "fail" you mean "crash", then yes, that's bad. However, the device may return less data. The while loop of my patch, 24d720b726c1a85f1962831ac30ad4d2ef8276b1, will correctly parse the returned
less data.
> but I have seen an example of a device doing exactly this
> (except that
> it was for INQUIRY data rather than MODE SENSE data --
> which is perhaps
> even worse!).
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-23 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 21:29 [PATCH] sd: Fix regression in sd_read_cache_type Alan Stern
2011-03-23 14:06 ` Luben Tuikov
2011-03-23 15:16 ` James Bottomley
2011-03-23 15:54 ` Luben Tuikov
2011-03-23 16:12 ` Alan Stern
2011-03-23 16:44 ` Luben Tuikov [this message]
2011-03-23 17:23 ` Alan Stern
2011-03-23 17:55 ` Luben Tuikov
2011-03-23 18:30 ` Alan Stern
2011-03-23 16:18 ` [PATCH ver. 2] " Alan Stern
2011-03-23 17:40 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529298.55791.qm@web31812.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=richard@r-senior.demon.co.uk \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox