From: Chen Gang <gang.chen.5i5j@gmail.com>
To: rkuo <rkuo@codeaurora.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Bottomley@parallels.com, linux-scsi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"
Date: Tue, 03 Dec 2013 19:42:01 +0800 [thread overview]
Message-ID: <529DC389.6060102@gmail.com> (raw)
In-Reply-To: <20131202213243.GA20646@codeaurora.org>
On 12/03/2013 05:32 AM, rkuo wrote:
> On Mon, Dec 02, 2013 at 06:14:33PM +0800, Chen Gang wrote:
>> If one issue occurs, normally, both sides need improvement.
>>
>> For our issue:
>>
>> - need try to keep uapi no touch ("arch/hexagon/uapi/asm/registers.h").
>>
>> - improving our module is much easier than improving hexagon.
>>
>> - for 'SP', it is really short enough to like a register name.
>> SG_POOL seems more suitable for our 'sgpool' related operations.
>>
>>
>> It will be better to improve hexagon too, but it is not quit easy (maybe
>> have to bear it), it is uapi :-(
>
> I can't speak for SCSI, but that define in Hexagon isn't really used outside
> of that file anyways (the two SP macros themselves). I'm also pretty sure
> the userspace isn't currently using it anyways. Seeing as it's not really
> buying us anything, I'm fine with just removing it and continuing to review
> the other defines. I'll make that change and test it locally.
>
OK, thanks.
>
> Thanks,
> Richard Kuo
>
>
--
Chen Gang
next prev parent reply other threads:[~2013-12-03 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528AEFB7.4060301@gmail.com>
[not found] ` <20131125011938.GB18921@codeaurora.org>
[not found] ` <5292B845.3010404@gmail.com>
[not found] ` <5292B8A0.7020409@gmail.com>
[not found] ` <5294255E.7040105@gmail.com>
2013-11-27 2:29 ` [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP" Chen Gang
2013-12-01 16:17 ` Bart Van Assche
2013-12-02 0:34 ` Chen Gang
2013-12-02 0:49 ` James Bottomley
2013-12-02 10:14 ` Chen Gang
2013-12-02 21:32 ` rkuo
2013-12-03 11:42 ` Chen Gang [this message]
2013-12-04 2:42 ` [PATCH v2] drivers: scsi: scsi_lib.c: use SG_POOL instead of SP Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DC389.6060102@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=Bottomley@parallels.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).