From: Chen Gang <gang.chen.5i5j@gmail.com>
To: rkuo <rkuo@codeaurora.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Bottomley@parallels.com, linux-scsi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] drivers: scsi: scsi_lib.c: use SG_POOL instead of SP
Date: Wed, 04 Dec 2013 10:42:41 +0800 [thread overview]
Message-ID: <529E96A1.3060400@gmail.com> (raw)
In-Reply-To: <20131202213243.GA20646@codeaurora.org>
the macro SP is too common to make conflict with others, so recommend
to use another more readable and non-conflict macro SG_POOL instead of
(and recommend others do not use SP either).
The related warning (with allmodconfig for hexagon):
CC [M] drivers/scsi/scsi_lib.o
drivers/scsi/scsi_lib.c:46:0: warning: "SP" redefined [enabled by default]
arch/hexagon/include/uapi/asm/registers.h:9:0: note: this is the location of the previous definition
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/scsi/scsi_lib.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 7bd7f0d..19967fa 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -43,28 +43,28 @@ struct scsi_host_sg_pool {
mempool_t *pool;
};
-#define SP(x) { x, "sgpool-" __stringify(x) }
+#define SG_POOL(x) { x, "sgpool-" __stringify(x) }
#if (SCSI_MAX_SG_SEGMENTS < 32)
#error SCSI_MAX_SG_SEGMENTS is too small (must be 32 or greater)
#endif
static struct scsi_host_sg_pool scsi_sg_pools[] = {
- SP(8),
- SP(16),
+ SG_POOL(8),
+ SG_POOL(16),
#if (SCSI_MAX_SG_SEGMENTS > 32)
- SP(32),
+ SG_POOL(32),
#if (SCSI_MAX_SG_SEGMENTS > 64)
- SP(64),
+ SG_POOL(64),
#if (SCSI_MAX_SG_SEGMENTS > 128)
- SP(128),
+ SG_POOL(128),
#if (SCSI_MAX_SG_SEGMENTS > 256)
#error SCSI_MAX_SG_SEGMENTS is too large (256 MAX)
#endif
#endif
#endif
#endif
- SP(SCSI_MAX_SG_SEGMENTS)
+ SG_POOL(SCSI_MAX_SG_SEGMENTS)
};
-#undef SP
+#undef SG_POOL
struct kmem_cache *scsi_sdb_cache;
--
1.7.7.6
prev parent reply other threads:[~2013-12-04 2:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528AEFB7.4060301@gmail.com>
[not found] ` <20131125011938.GB18921@codeaurora.org>
[not found] ` <5292B845.3010404@gmail.com>
[not found] ` <5292B8A0.7020409@gmail.com>
[not found] ` <5294255E.7040105@gmail.com>
2013-11-27 2:29 ` [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP" Chen Gang
2013-12-01 16:17 ` Bart Van Assche
2013-12-02 0:34 ` Chen Gang
2013-12-02 0:49 ` James Bottomley
2013-12-02 10:14 ` Chen Gang
2013-12-02 21:32 ` rkuo
2013-12-03 11:42 ` Chen Gang
2013-12-04 2:42 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E96A1.3060400@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=Bottomley@parallels.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).