From: Mike Christie <michaelc@cs.wisc.edu>
To: bugzilla-daemon@bugzilla.kernel.org
Cc: linux-scsi@vger.kernel.org,
"Jayamohan.Kallickal@Emulex.Com" <Jayamohan.Kallickal@emulex.com>
Subject: Re: [Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ?
Date: Thu, 19 Dec 2013 01:16:21 -0600 [thread overview]
Message-ID: <52B29D45.1030101@cs.wisc.edu> (raw)
In-Reply-To: <bug-67091-11613-8nIo1tBSXu@https.bugzilla.kernel.org/>
On 12/18/2013 08:24 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=67091
>
> Alan <alan@lxorguk.ukuu.org.uk> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |alan@lxorguk.ukuu.org.uk
> Component|Other |Other
> Assignee|drivers_other@kernel-bugs.o |scsi_drivers-other@kernel-b
> |sdl.org |ugs.osdl.org
> Product|Drivers |SCSI Drivers
>
Jay,
I thought we fixed that bug. I am not seeing a patch though. I think we
wanted to be checking against the sc passed in. Patch is compile tested
only.
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 1f37505..5642a9b 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -325,7 +325,7 @@ static int beiscsi_eh_device_reset(struct scsi_cmnd *sc)
if (!abrt_task->sc || abrt_task->state == ISCSI_TASK_FREE)
continue;
- if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
+ if (sc->device->lun != abrt_task->sc->device->lun)
continue;
/* Invalidate WRB Posted for this Task */
prev parent reply other threads:[~2013-12-19 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-67091-11613@https.bugzilla.kernel.org/>
2013-12-18 14:24 ` [Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ? bugzilla-daemon
2013-12-19 7:16 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B29D45.1030101@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=Jayamohan.Kallickal@emulex.com \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).