Re: [PATCH v2 0/7] scsi_debug: several bug fixes and enable clustering support

Douglas Gilbert
2014-01-19T16:00:07Z

On 14-01-19 08:51 AM, Akinobu Mita wrote:
> This patch set includes several bug fixes and patches for enabling
> clustering support for scsi_debug.
>
> The reason why I would like to enable clustering is to test commands
> with huge transfer length. Without enabling clustering support, the
> transfer length for read and write scsi commands is limited upto 8MB
> when page size is 4KB and sg_tablesize is 2048
> (= SCSI_MAX_SG_CHAIN_SEGMENTS).
>
> Changes from v1:
> - remove unnecessary irqsave/irqrestore while iterating sg mapping
> - protect device access with atomic_rw lock
> - make clustering module parameter writable
>
> Akinobu Mita (7):
> scsi_debug: fix false positive logical block reference tag check fail
> scsi_debug: make pseudo_primary static
> scsi_debug: fix duplicate dif_errors increment
> scsi_debug: fix resp_xdwriteread() return value when running out of
> memory
> scsi_debug: prepare to enable clustering
> scsi_debug: protect device access with atomic_rw lock
> scsi_debug: add ability to enable clustering
>
> drivers/scsi/scsi_debug.c | 141 +++++++++++++++++++++++++++-------------------
> 1 file changed, 82 insertions(+), 59 deletions(-)
>
> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
> Cc: Douglas Gilbert <dgilbert@interlog.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org

The parts of this patch that I understand look fine. Perhaps
Martin should "ack" it, if he sees fit.

Reviewed-by: Douglas Gilbert <dgilbert@interlog.com>