From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kallickal <jayamohank@gmail.com>
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
John Soni Jose <sony.john-n@emulex.com>
Subject: Re: [PATCH 3/8] be2iscsi : Fix IRQ_Affinity support in driver.
Date: Sat, 01 Feb 2014 16:46:46 -0600 [thread overview]
Message-ID: <52ED7956.6000901@cs.wisc.edu> (raw)
In-Reply-To: <1390979807-16718-3-git-send-email-Jayamohan.Kallickal@emulex.com>
On 01/29/2014 01:16 AM, Jayamohan Kallickal wrote:
> +
> + if (msix_vec) {
> + if (cpu_online(cpu_index))
> + cpumask_set_cpu(cpu_index,
> + &phba->msix_cpu_map[
> + cpu_index].affinity_mask);
> + else
> + cpumask_copy(&phba->msix_cpu_map[
> + cpu_index].affinity_mask,
> + cpu_online_mask);
> +
I think this code works, but I am not sure if this what you wanted to do.
It seems we set num_cpus in find_num_cpus. It can be the number of
online or some driver limited value. We then loop for (i = 0; i <
num_cpus i++). Above, then if the cpu is not online then you just set it
to the online cpu mask instead of a specific cpu.
Is it possible num_cpus can be 7, but it is possible the online cpus are
0 to 5 and 8. So, when you loop the last vec is set to all online cpus
instead of 8 when it is possible to set it to a specific cpu?
Do you want to be doing a for_each_online_cpu to loop instead?
next prev parent reply other threads:[~2014-02-01 22:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 7:16 [PATCH 1/8] be2iscsi: Fix handling timed out MBX completion from FW Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH 2/8] be2iscsi: Fix port speed typo in driver Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH 3/8] be2iscsi : Fix IRQ_Affinity support " Jayamohan Kallickal
2014-02-01 22:46 ` Mike Christie [this message]
2014-02-05 5:09 ` Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH 4/8] be2iscsi: Fix doorbell format for EQ/CQ/RQ s per SLI spec Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH 5/8] be2iscsi: Fix the session cleanup when reboot/shutdown happens Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH 6/8] be2iscsi: Fix scsi_cmnd leakage in driver Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH 7/8] be2iscsi : Fix DMA Out of SW-IOMMU space error Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH 8/8] be2iscsi : Bump the driver version Jayamohan Kallickal
2014-01-29 7:16 ` [PATCH V2 0/8] be2iscsi: Update to 10.2.125.0 Jayamohan Kallickal
2014-02-05 21:44 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ED7956.6000901@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jayamohan.kallickal@emulex.com \
--cc=jayamohank@gmail.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sony.john-n@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox