* [PATCH v2 0/9] Phase out pci_enable_msi_block()
@ 2014-01-17 16:02 Alexander Gordeev
2014-01-17 16:02 ` [PATCH v2 3/9] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Alexander Gordeev @ 2014-01-17 16:02 UTC (permalink / raw)
To: linux-kernel
Cc: Alexander Gordeev, Brian King, Tejun Heo, Matthew Wilcox,
Alex Williamson, Kalle Valo, Vladimir Kondratiev, linux-wireless,
wil6210, ath10k, linux-nvme, linux-ide, linux-scsi, kvm,
linux-pci
This series is against "next" branch in Bjorn's repo:
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
Changes from v1 to v2:
- added a regression fix "ahci: Fix broken fallback to single
MSI mode" as patch 1/9;
- the series is reordered to move the regression fix in front;
- at Bjorn's request pci_enable_msi() is un-deprecated;
- as result, pci_enable_msi_range(pdev, 1, 1) styled calls
rolled back to pci_enable_msi(pdev);
- nvme bug fix moved out as a separate patch 5/9 "nvme: Fix
invalid call to irq_set_affinity_hint()"
- patches changelog elaborated a bit;
Bjorn,
As the release is supposedly this weekend, do you prefer
the patches to go to your tree or to individual trees after
the release?
Thanks!
Alexander Gordeev (9):
ahci: Fix broken fallback to single MSI mode
ahci: Use pci_enable_msi_range()
ipr: Get rid of superfluous call to pci_disable_msi/msix()
ipr: Use pci_enable_msi_range() and pci_enable_msix_range()
nvme: Fix invalid call to irq_set_affinity_hint()
nvme: Use pci_enable_msi_range() and pci_enable_msix_range()
vfio: Use pci_enable_msi_range() and pci_enable_msix_range()
ath10k: Use pci_enable_msi_range()
wil6210: Use pci_enable_msi_range()
drivers/ata/ahci.c | 18 +++++-----
drivers/block/nvme-core.c | 33 ++++-------------
drivers/net/wireless/ath/ath10k/pci.c | 20 +++++-----
drivers/net/wireless/ath/wil6210/pcie_bus.c | 36 ++++++++++---------
drivers/scsi/ipr.c | 51 +++++++++-----------------
drivers/vfio/pci/vfio_pci_intrs.c | 12 ++++--
6 files changed, 72 insertions(+), 98 deletions(-)
--
1.7.7.6
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH v2 3/9] ipr: Get rid of superfluous call to pci_disable_msi/msix() 2014-01-17 16:02 [PATCH v2 0/9] Phase out pci_enable_msi_block() Alexander Gordeev @ 2014-01-17 16:02 ` Alexander Gordeev 2014-01-17 16:02 ` [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev 2014-01-17 21:00 ` [PATCH v2 0/9] Phase out pci_enable_msi_block() Bjorn Helgaas 2 siblings, 0 replies; 19+ messages in thread From: Alexander Gordeev @ 2014-01-17 16:02 UTC (permalink / raw) To: linux-kernel; +Cc: Alexander Gordeev, Brian King, linux-scsi, kvm, linux-pci There is no need to call pci_disable_msi() or pci_disable_msix() in case the call to pci_enable_msi() or pci_enable_msix() failed. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> --- drivers/scsi/ipr.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 36ac1c3..fb57e21 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -9255,10 +9255,8 @@ static int ipr_enable_msix(struct ipr_ioa_cfg *ioa_cfg) while ((err = pci_enable_msix(ioa_cfg->pdev, entries, vectors)) > 0) vectors = err; - if (err < 0) { - pci_disable_msix(ioa_cfg->pdev); + if (err < 0) return err; - } if (!err) { for (i = 0; i < vectors; i++) @@ -9278,10 +9276,8 @@ static int ipr_enable_msi(struct ipr_ioa_cfg *ioa_cfg) while ((err = pci_enable_msi_block(ioa_cfg->pdev, vectors)) > 0) vectors = err; - if (err < 0) { - pci_disable_msi(ioa_cfg->pdev); + if (err < 0) return err; - } if (!err) { for (i = 0; i < vectors; i++) -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-17 16:02 [PATCH v2 0/9] Phase out pci_enable_msi_block() Alexander Gordeev 2014-01-17 16:02 ` [PATCH v2 3/9] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev @ 2014-01-17 16:02 ` Alexander Gordeev 2014-01-28 9:54 ` Alexander Gordeev 2014-01-17 21:00 ` [PATCH v2 0/9] Phase out pci_enable_msi_block() Bjorn Helgaas 2 siblings, 1 reply; 19+ messages in thread From: Alexander Gordeev @ 2014-01-17 16:02 UTC (permalink / raw) To: linux-kernel; +Cc: Alexander Gordeev, Brian King, linux-scsi, kvm, linux-pci As result deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> --- drivers/scsi/ipr.c | 47 ++++++++++++++++++----------------------------- 1 files changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index fb57e21..3841298 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -9245,47 +9245,36 @@ ipr_get_chip_info(const struct pci_device_id *dev_id) static int ipr_enable_msix(struct ipr_ioa_cfg *ioa_cfg) { struct msix_entry entries[IPR_MAX_MSIX_VECTORS]; - int i, err, vectors; + int i, vectors; for (i = 0; i < ARRAY_SIZE(entries); ++i) entries[i].entry = i; - vectors = ipr_number_of_msix; + vectors = pci_enable_msix_range(ioa_cfg->pdev, entries, + 1, ipr_number_of_msix); + if (vectors < 0) + return vectors; - while ((err = pci_enable_msix(ioa_cfg->pdev, entries, vectors)) > 0) - vectors = err; + for (i = 0; i < vectors; i++) + ioa_cfg->vectors_info[i].vec = entries[i].vector; + ioa_cfg->nvectors = vectors; - if (err < 0) - return err; - - if (!err) { - for (i = 0; i < vectors; i++) - ioa_cfg->vectors_info[i].vec = entries[i].vector; - ioa_cfg->nvectors = vectors; - } - - return err; + return 0; } static int ipr_enable_msi(struct ipr_ioa_cfg *ioa_cfg) { - int i, err, vectors; + int i, vectors; - vectors = ipr_number_of_msix; + vectors = pci_enable_msi_range(ioa_cfg->pdev, 1, ipr_number_of_msix); + if (vectors < 0) + return vectors; - while ((err = pci_enable_msi_block(ioa_cfg->pdev, vectors)) > 0) - vectors = err; + for (i = 0; i < vectors; i++) + ioa_cfg->vectors_info[i].vec = ioa_cfg->pdev->irq + i; + ioa_cfg->nvectors = vectors; - if (err < 0) - return err; - - if (!err) { - for (i = 0; i < vectors; i++) - ioa_cfg->vectors_info[i].vec = ioa_cfg->pdev->irq + i; - ioa_cfg->nvectors = vectors; - } - - return err; + return 0; } static void name_msi_vectors(struct ipr_ioa_cfg *ioa_cfg) @@ -9350,7 +9339,7 @@ static irqreturn_t ipr_test_intr(int irq, void *devp) * ipr_test_msi - Test for Message Signaled Interrupt (MSI) support. * @pdev: PCI device struct * - * Description: The return value from pci_enable_msi() can not always be + * Description: The return value from pci_enable_msi_range() can not always be * trusted. This routine sets up and initiates a test interrupt to determine * if the interrupt is received via the ipr_test_intr() service routine. * If the tests fails, the driver will fall back to LSI. -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-17 16:02 ` [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev @ 2014-01-28 9:54 ` Alexander Gordeev 2014-01-28 15:28 ` Brian King 0 siblings, 1 reply; 19+ messages in thread From: Alexander Gordeev @ 2014-01-28 9:54 UTC (permalink / raw) To: Brian King, James E.J. Bottomley; +Cc: linux-scsi, kvm, linux-pci, linux-kernel On Fri, Jan 17, 2014 at 05:02:18PM +0100, Alexander Gordeev wrote: > As result deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() and pci_enable_msix_range() > interfaces. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Brian, James, Could you please review patches 3 and 4? Thanks! -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-28 9:54 ` Alexander Gordeev @ 2014-01-28 15:28 ` Brian King 2014-01-29 13:26 ` Alexander Gordeev 0 siblings, 1 reply; 19+ messages in thread From: Brian King @ 2014-01-28 15:28 UTC (permalink / raw) To: Alexander Gordeev Cc: Brian King, James E.J. Bottomley, linux-scsi, kvm, linux-pci, linux-kernel, Wendy Xiong On 01/28/2014 03:54 AM, Alexander Gordeev wrote: > On Fri, Jan 17, 2014 at 05:02:18PM +0100, Alexander Gordeev wrote: >> As result deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be updated to use the >> new pci_enable_msi_range() and pci_enable_msix_range() >> interfaces. >> >> Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > > Brian, James, > > Could you please review patches 3 and 4? These look like they will conflict with a recent patch to the ipr driver: http://www.spinics.net/lists/linux-scsi/msg71644.html Do you want me to rediff your patches on top of this one, or do you want to keep the entire MSI series together and do the rediff? Otherwise the patches seem fine. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-28 15:28 ` Brian King @ 2014-01-29 13:26 ` Alexander Gordeev 2014-01-30 14:06 ` Alexander Gordeev 0 siblings, 1 reply; 19+ messages in thread From: Alexander Gordeev @ 2014-01-29 13:26 UTC (permalink / raw) To: Brian King Cc: James E.J. Bottomley, linux-scsi, kvm, linux-pci, linux-kernel, Wendy Xiong On Tue, Jan 28, 2014 at 09:28:45AM -0600, Brian King wrote: Thanks for the review, Brian! > These look like they will conflict with a recent patch to > the ipr driver: > > http://www.spinics.net/lists/linux-scsi/msg71644.html BTW, this one does not appear ACKed. > Do you want me to rediff your patches on top of this one, > or do you want to keep the entire MSI series together > and do the rediff? Otherwise the patches seem fine. I would prefer the former. @Bjorn, please let us know if you prefer otherwise. > Thanks, > > Brian > > > -- > Brian King > Power Linux I/O > IBM Linux Technology Center > > -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-29 13:26 ` Alexander Gordeev @ 2014-01-30 14:06 ` Alexander Gordeev 2014-01-30 14:09 ` [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev ` (2 more replies) 0 siblings, 3 replies; 19+ messages in thread From: Alexander Gordeev @ 2014-01-30 14:06 UTC (permalink / raw) To: Brian King; +Cc: linux-scsi, linux-pci, linux-kernel, Wendy Xiong On Wed, Jan 29, 2014 at 02:26:52PM +0100, Alexander Gordeev wrote: > > Do you want me to rediff your patches on top of this one, > > or do you want to keep the entire MSI series together > > and do the rediff? Otherwise the patches seem fine. > > I would prefer the former. Hi Brian, I am sending the refreshed patches on top of "ipr: Handle early EEH". -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() 2014-01-30 14:06 ` Alexander Gordeev @ 2014-01-30 14:09 ` Alexander Gordeev 2014-02-03 15:20 ` Brian King 2014-01-30 14:10 ` [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev 2014-02-24 8:12 ` [PATCH v2 4/9] " Alexander Gordeev 2 siblings, 1 reply; 19+ messages in thread From: Alexander Gordeev @ 2014-01-30 14:09 UTC (permalink / raw) To: Brian King; +Cc: linux-scsi, linux-pci, linux-kernel, Wendy Xiong There is no need to call pci_disable_msi() or pci_disable_msix() in case the call to pci_enable_msi() or pci_enable_msix() failed. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> --- drivers/scsi/ipr.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 96c10ce..48d0cfc 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -9329,7 +9329,6 @@ static int ipr_enable_msix(struct ipr_ioa_cfg *ioa_cfg) if (err < 0) { ipr_wait_for_pci_err_recovery(ioa_cfg); - pci_disable_msix(ioa_cfg->pdev); return err; } @@ -9353,7 +9352,6 @@ static int ipr_enable_msi(struct ipr_ioa_cfg *ioa_cfg) if (err < 0) { ipr_wait_for_pci_err_recovery(ioa_cfg); - pci_disable_msi(ioa_cfg->pdev); return err; } -- 1.7.7.6 -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() 2014-01-30 14:09 ` [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev @ 2014-02-03 15:20 ` Brian King 0 siblings, 0 replies; 19+ messages in thread From: Brian King @ 2014-02-03 15:20 UTC (permalink / raw) To: Alexander Gordeev; +Cc: linux-scsi, linux-pci, linux-kernel, Wendy Xiong Acked-by: Brian King <brking@linux.vnet.ibm.com> -- Brian King Power Linux I/O IBM Linux Technology Center ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-30 14:06 ` Alexander Gordeev 2014-01-30 14:09 ` [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev @ 2014-01-30 14:10 ` Alexander Gordeev 2014-02-03 15:22 ` Brian King 2014-02-24 8:12 ` [PATCH v2 4/9] " Alexander Gordeev 2 siblings, 1 reply; 19+ messages in thread From: Alexander Gordeev @ 2014-01-30 14:10 UTC (permalink / raw) To: Brian King; +Cc: linux-scsi, linux-pci, linux-kernel, Wendy Xiong As result deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> --- drivers/scsi/ipr.c | 47 ++++++++++++++++++----------------------------- 1 files changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 48d0cfc..70f40ca 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -9317,51 +9317,40 @@ static void ipr_wait_for_pci_err_recovery(struct ipr_ioa_cfg *ioa_cfg) static int ipr_enable_msix(struct ipr_ioa_cfg *ioa_cfg) { struct msix_entry entries[IPR_MAX_MSIX_VECTORS]; - int i, err, vectors; + int i, vectors; for (i = 0; i < ARRAY_SIZE(entries); ++i) entries[i].entry = i; - vectors = ipr_number_of_msix; - - while ((err = pci_enable_msix(ioa_cfg->pdev, entries, vectors)) > 0) - vectors = err; - - if (err < 0) { + vectors = pci_enable_msix_range(ioa_cfg->pdev, + entries, 1, ipr_number_of_msix); + if (vectors < 0) { ipr_wait_for_pci_err_recovery(ioa_cfg); - return err; + return vectors; } - if (!err) { - for (i = 0; i < vectors; i++) - ioa_cfg->vectors_info[i].vec = entries[i].vector; - ioa_cfg->nvectors = vectors; - } + for (i = 0; i < vectors; i++) + ioa_cfg->vectors_info[i].vec = entries[i].vector; + ioa_cfg->nvectors = vectors; - return err; + return 0; } static int ipr_enable_msi(struct ipr_ioa_cfg *ioa_cfg) { - int i, err, vectors; + int i, vectors; - vectors = ipr_number_of_msix; - - while ((err = pci_enable_msi_block(ioa_cfg->pdev, vectors)) > 0) - vectors = err; - - if (err < 0) { + vectors = pci_enable_msi_range(ioa_cfg->pdev, 1, ipr_number_of_msix); + if (vectors < 0) { ipr_wait_for_pci_err_recovery(ioa_cfg); - return err; + return vectors; } - if (!err) { - for (i = 0; i < vectors; i++) - ioa_cfg->vectors_info[i].vec = ioa_cfg->pdev->irq + i; - ioa_cfg->nvectors = vectors; - } + for (i = 0; i < vectors; i++) + ioa_cfg->vectors_info[i].vec = ioa_cfg->pdev->irq + i; + ioa_cfg->nvectors = vectors; - return err; + return 0; } static void name_msi_vectors(struct ipr_ioa_cfg *ioa_cfg) @@ -9426,7 +9415,7 @@ static irqreturn_t ipr_test_intr(int irq, void *devp) * ipr_test_msi - Test for Message Signaled Interrupt (MSI) support. * @pdev: PCI device struct * - * Description: The return value from pci_enable_msi() can not always be + * Description: The return value from pci_enable_msi_range() can not always be * trusted. This routine sets up and initiates a test interrupt to determine * if the interrupt is received via the ipr_test_intr() service routine. * If the tests fails, the driver will fall back to LSI. -- 1.7.7.6 -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-30 14:10 ` [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev @ 2014-02-03 15:22 ` Brian King 0 siblings, 0 replies; 19+ messages in thread From: Brian King @ 2014-02-03 15:22 UTC (permalink / raw) To: Alexander Gordeev; +Cc: linux-scsi, linux-pci, linux-kernel, Wendy Xiong Acked-by: Brian King <brking@linux.vnet.ibm.com> -- Brian King Power Linux I/O IBM Linux Technology Center ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-01-30 14:06 ` Alexander Gordeev 2014-01-30 14:09 ` [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev 2014-01-30 14:10 ` [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev @ 2014-02-24 8:12 ` Alexander Gordeev 2014-02-26 15:02 ` Brian King 2 siblings, 1 reply; 19+ messages in thread From: Alexander Gordeev @ 2014-02-24 8:12 UTC (permalink / raw) To: Brian King, James Bottomley Cc: linux-scsi, linux-pci, linux-kernel, Wendy Xiong On Thu, Jan 30, 2014 at 03:06:30PM +0100, Alexander Gordeev wrote: > On Wed, Jan 29, 2014 at 02:26:52PM +0100, Alexander Gordeev wrote: > > > Do you want me to rediff your patches on top of this one, > > > or do you want to keep the entire MSI series together > > > and do the rediff? Otherwise the patches seem fine. > > > > I would prefer the former. > > Hi Brian, > > I am sending the refreshed patches on top of "ipr: Handle early EEH". Hi Brian, What three the two patches you ACKed are against? Should I ask James to take them? Thanks! -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() 2014-02-24 8:12 ` [PATCH v2 4/9] " Alexander Gordeev @ 2014-02-26 15:02 ` Brian King 0 siblings, 0 replies; 19+ messages in thread From: Brian King @ 2014-02-26 15:02 UTC (permalink / raw) To: Alexander Gordeev Cc: James Bottomley, linux-scsi, linux-pci, linux-kernel, Wendy Xiong On 02/24/2014 02:12 AM, Alexander Gordeev wrote: > On Thu, Jan 30, 2014 at 03:06:30PM +0100, Alexander Gordeev wrote: >> On Wed, Jan 29, 2014 at 02:26:52PM +0100, Alexander Gordeev wrote: >>>> Do you want me to rediff your patches on top of this one, >>>> or do you want to keep the entire MSI series together >>>> and do the rediff? Otherwise the patches seem fine. >>> >>> I would prefer the former. >> >> Hi Brian, >> >> I am sending the refreshed patches on top of "ipr: Handle early EEH". > > Hi Brian, > > What three the two patches you ACKed are against? > Should I ask James to take them? Wendy - can you pull in these two patches from Alexander and rebase on top of the latest patches you've sent upstream? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/9] Phase out pci_enable_msi_block() 2014-01-17 16:02 [PATCH v2 0/9] Phase out pci_enable_msi_block() Alexander Gordeev 2014-01-17 16:02 ` [PATCH v2 3/9] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev 2014-01-17 16:02 ` [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev @ 2014-01-17 21:00 ` Bjorn Helgaas 2014-01-18 7:15 ` Alexander Gordeev 2014-01-29 13:59 ` Alexander Gordeev 2 siblings, 2 replies; 19+ messages in thread From: Bjorn Helgaas @ 2014-01-17 21:00 UTC (permalink / raw) To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Brian King, Tejun Heo, Matthew Wilcox, Alex Williamson, Kalle Valo, Vladimir Kondratiev, linux-wireless, wil6210, ath10k, linux-nvme, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org On Fri, Jan 17, 2014 at 9:02 AM, Alexander Gordeev <agordeev@redhat.com> wrote: > This series is against "next" branch in Bjorn's repo: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > > Changes from v1 to v2: > - added a regression fix "ahci: Fix broken fallback to single > MSI mode" as patch 1/9; > - the series is reordered to move the regression fix in front; > - at Bjorn's request pci_enable_msi() is un-deprecated; > - as result, pci_enable_msi_range(pdev, 1, 1) styled calls > rolled back to pci_enable_msi(pdev); > - nvme bug fix moved out as a separate patch 5/9 "nvme: Fix > invalid call to irq_set_affinity_hint()" > - patches changelog elaborated a bit; > > Bjorn, > > As the release is supposedly this weekend, do you prefer > the patches to go to your tree or to individual trees after > the release? I'd be happy to merge them, except for the fact that they probably wouldn't have any time in -next before I ask Linus to pull them. So how about if we wait until after the release, ask the area maintainers to take them, and if they don't take them, I'll put them in my tree for v3.15? Bjorn ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/9] Phase out pci_enable_msi_block() 2014-01-17 21:00 ` [PATCH v2 0/9] Phase out pci_enable_msi_block() Bjorn Helgaas @ 2014-01-18 7:15 ` Alexander Gordeev 2014-01-18 14:38 ` Bjorn Helgaas 2014-01-29 13:59 ` Alexander Gordeev 1 sibling, 1 reply; 19+ messages in thread From: Alexander Gordeev @ 2014-01-18 7:15 UTC (permalink / raw) To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, Brian King, Tejun Heo, Matthew Wilcox, Alex Williamson, Kalle Valo, Vladimir Kondratiev, linux-wireless, wil6210, ath10k, linux-nvme, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: > > As the release is supposedly this weekend, do you prefer > > the patches to go to your tree or to individual trees after > > the release? > > I'd be happy to merge them, except for the fact that they probably > wouldn't have any time in -next before I ask Linus to pull them. So > how about if we wait until after the release, ask the area maintainers > to take them, and if they don't take them, I'll put them in my tree > for v3.15? Patch 11 depends on patches 1-10, so I am not sure how to better handle it. Whatever works for you ;) I am only concerned with a regression fix "ahci: Fix broken fallback to single MSI mode" which would be nice to have in 3.14. But it seems pretty much too late. > Bjorn Thanks! -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/9] Phase out pci_enable_msi_block() 2014-01-18 7:15 ` Alexander Gordeev @ 2014-01-18 14:38 ` Bjorn Helgaas 2014-01-18 14:59 ` Tejun Heo 0 siblings, 1 reply; 19+ messages in thread From: Bjorn Helgaas @ 2014-01-18 14:38 UTC (permalink / raw) To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Brian King, Tejun Heo, Matthew Wilcox, Alex Williamson, Kalle Valo, Vladimir Kondratiev, linux-wireless, wil6210, ath10k, linux-nvme, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev <agordeev@redhat.com> wrote: > On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: >> > As the release is supposedly this weekend, do you prefer >> > the patches to go to your tree or to individual trees after >> > the release? >> >> I'd be happy to merge them, except for the fact that they probably >> wouldn't have any time in -next before I ask Linus to pull them. So >> how about if we wait until after the release, ask the area maintainers >> to take them, and if they don't take them, I'll put them in my tree >> for v3.15? > > Patch 11 depends on patches 1-10, so I am not sure how to better handle it. > Whatever works for you ;) > > I am only concerned with a regression fix "ahci: Fix broken fallback to > single MSI mode" which would be nice to have in 3.14. But it seems pretty > much too late. Tejun, if you want to ack that one, I can put it in either the first 3.14 pull request or a subsequent one. Either way, since it's a regression fix, we should be able to get it in 3.14. Bjorn ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/9] Phase out pci_enable_msi_block() 2014-01-18 14:38 ` Bjorn Helgaas @ 2014-01-18 14:59 ` Tejun Heo 2014-01-29 21:48 ` Bjorn Helgaas 0 siblings, 1 reply; 19+ messages in thread From: Tejun Heo @ 2014-01-18 14:59 UTC (permalink / raw) To: Bjorn Helgaas Cc: Alexander Gordeev, linux-kernel@vger.kernel.org, Brian King, Matthew Wilcox, Alex Williamson, Kalle Valo, Vladimir Kondratiev, linux-wireless, wil6210, ath10k, linux-nvme, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org On Sat, Jan 18, 2014 at 07:38:55AM -0700, Bjorn Helgaas wrote: > On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev <agordeev@redhat.com> wrote: > > On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: > >> > As the release is supposedly this weekend, do you prefer > >> > the patches to go to your tree or to individual trees after > >> > the release? > >> > >> I'd be happy to merge them, except for the fact that they probably > >> wouldn't have any time in -next before I ask Linus to pull them. So > >> how about if we wait until after the release, ask the area maintainers > >> to take them, and if they don't take them, I'll put them in my tree > >> for v3.15? > > > > Patch 11 depends on patches 1-10, so I am not sure how to better handle it. > > Whatever works for you ;) > > > > I am only concerned with a regression fix "ahci: Fix broken fallback to > > single MSI mode" which would be nice to have in 3.14. But it seems pretty > > much too late. > > Tejun, if you want to ack that one, I can put it in either the first > 3.14 pull request or a subsequent one. Either way, since it's a > regression fix, we should be able to get it in 3.14. Acked-by: Tejun Heo <tj@kernel.org> Please feel free to route it any way you see fit. Thanks! -- tejun ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/9] Phase out pci_enable_msi_block() 2014-01-18 14:59 ` Tejun Heo @ 2014-01-29 21:48 ` Bjorn Helgaas 0 siblings, 0 replies; 19+ messages in thread From: Bjorn Helgaas @ 2014-01-29 21:48 UTC (permalink / raw) To: Tejun Heo Cc: Alexander Gordeev, linux-kernel@vger.kernel.org, Brian King, Matthew Wilcox, Alex Williamson, Kalle Valo, Vladimir Kondratiev, linux-wireless, wil6210, ath10k, linux-nvme, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org On Sat, Jan 18, 2014 at 09:59:40AM -0500, Tejun Heo wrote: > On Sat, Jan 18, 2014 at 07:38:55AM -0700, Bjorn Helgaas wrote: > > On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev <agordeev@redhat.com> wrote: > > > On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: > > >> > As the release is supposedly this weekend, do you prefer > > >> > the patches to go to your tree or to individual trees after > > >> > the release? > > >> > > >> I'd be happy to merge them, except for the fact that they probably > > >> wouldn't have any time in -next before I ask Linus to pull them. So > > >> how about if we wait until after the release, ask the area maintainers > > >> to take them, and if they don't take them, I'll put them in my tree > > >> for v3.15? > > > > > > Patch 11 depends on patches 1-10, so I am not sure how to better handle it. > > > Whatever works for you ;) > > > > > > I am only concerned with a regression fix "ahci: Fix broken fallback to > > > single MSI mode" which would be nice to have in 3.14. But it seems pretty > > > much too late. > > > > Tejun, if you want to ack that one, I can put it in either the first > > 3.14 pull request or a subsequent one. Either way, since it's a > > regression fix, we should be able to get it in 3.14. > > Acked-by: Tejun Heo <tj@kernel.org> > > Please feel free to route it any way you see fit. I applied the following to my pci/msi branch, since they had acks from maintainers (Tejun, I assumed your ack applies to both ahci patches): ahci: Fix broken fallback to single MSI mode ahci: Use pci_enable_msi_range() vfio: Use pci_enable_msi_range() and pci_enable_msix_range() wil6210: Use pci_enable_msi_range() I didn't do anything with these: ipr: Get rid of superfluous call to pci_disable_msi/msix() ipr: Use pci_enable_msi_range() and pci_enable_msix_range() The conflict with "ipr: Handle early EEH" needs to get resolved first. Either Alexander's patches need to go via the same tree as the EEH change, or the EEH change needs to be in some published tree so I can cherry-pick it. nvme: Fix invalid call to irq_set_affinity_hint() nvme: Use pci_enable_msi_range() and pci_enable_msix_range() These don't seem fully baked yet. If/when Keith acks them, I (or he) can merge them. ath10k: Use pci_enable_msi_range() This has been acked, but no longer applies to mainline (I'm currently at 0e47c969c65e). Bjorn ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/9] Phase out pci_enable_msi_block() 2014-01-17 21:00 ` [PATCH v2 0/9] Phase out pci_enable_msi_block() Bjorn Helgaas 2014-01-18 7:15 ` Alexander Gordeev @ 2014-01-29 13:59 ` Alexander Gordeev 1 sibling, 0 replies; 19+ messages in thread From: Alexander Gordeev @ 2014-01-29 13:59 UTC (permalink / raw) To: Alex Williamson, Kalle Valo, Vladimir Kondratiev Cc: linux-kernel@vger.kernel.org, Brian King, Tejun Heo, Matthew Wilcox, linux-wireless, wil6210, ath10k, linux-nvme, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: > > Bjorn, > > > > As the release is supposedly this weekend, do you prefer > > the patches to go to your tree or to individual trees after > > the release? > > I'd be happy to merge them, except for the fact that they probably > wouldn't have any time in -next before I ask Linus to pull them. So > how about if we wait until after the release, ask the area maintainers > to take them, and if they don't take them, I'll put them in my tree > for v3.15? Hi Gentleman, As the prerequisite commit 302a252 ("PCI/MSI: Add pci_enable_msi_range() and pci_enable_msix_range()") is in mainline now, could you please take the ACKed patches to your trees? Thanks! > Bjorn -- Regards, Alexander Gordeev agordeev@redhat.com ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2014-02-26 15:02 UTC | newest] Thread overview: 19+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-17 16:02 [PATCH v2 0/9] Phase out pci_enable_msi_block() Alexander Gordeev 2014-01-17 16:02 ` [PATCH v2 3/9] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev 2014-01-17 16:02 ` [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev 2014-01-28 9:54 ` Alexander Gordeev 2014-01-28 15:28 ` Brian King 2014-01-29 13:26 ` Alexander Gordeev 2014-01-30 14:06 ` Alexander Gordeev 2014-01-30 14:09 ` [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev 2014-02-03 15:20 ` Brian King 2014-01-30 14:10 ` [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev 2014-02-03 15:22 ` Brian King 2014-02-24 8:12 ` [PATCH v2 4/9] " Alexander Gordeev 2014-02-26 15:02 ` Brian King 2014-01-17 21:00 ` [PATCH v2 0/9] Phase out pci_enable_msi_block() Bjorn Helgaas 2014-01-18 7:15 ` Alexander Gordeev 2014-01-18 14:38 ` Bjorn Helgaas 2014-01-18 14:59 ` Tejun Heo 2014-01-29 21:48 ` Bjorn Helgaas 2014-01-29 13:59 ` Alexander Gordeev
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).