From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Tejun Heo <tj@kernel.org>, Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [PATCH 4/6] scsi: remove a useless get/put_device pair in scsi_request_fn
Date: Wed, 12 Feb 2014 12:38:10 +0100 [thread overview]
Message-ID: <52FB5D22.5070208@suse.de> (raw)
In-Reply-To: <20140206184417.890824661@bombadil.infradead.org>
On 02/06/2014 07:43 PM, Christoph Hellwig wrote:
> From: Bart Van Assche <bvanassche@acm.org>
>
> SCSI devices may only be removed by calling scsi_remove_device().
> That function must invoke blk_cleanup_queue() before the final put
> of sdev->sdev_gendev. Since blk_cleanup_queue() waits for the
> block queue to drain and then tears it down, scsi_request_fn cannot
> be active anymore after blk_cleanup_queue() has returned and hence
> the get_device()/put_device() pair in scsi_request_fn is unnecessary.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> Acked-by: Tejun Heo <tj@kernel.org>
> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Acked-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-12 11:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 18:43 [PATCH 0/6] first batch of SCSI data path micro-optimizations Christoph Hellwig
2014-02-06 18:43 ` [PATCH 1/6] scsi: avoid useless free_list lock roundtrips Christoph Hellwig
2014-02-12 10:53 ` Hannes Reinecke
2014-02-06 18:43 ` [PATCH 2/6] scsi: avoid taking host_lock in scsi_run_queue unless nessecary Christoph Hellwig
2014-02-12 11:08 ` Hannes Reinecke
2014-02-12 15:52 ` Christoph Hellwig
2014-02-06 18:43 ` [PATCH 3/6] scsi: do not manipulate device reference counts in scsi_get/put_command Christoph Hellwig
2014-02-12 11:37 ` Hannes Reinecke
2014-02-12 15:58 ` Christoph Hellwig
2014-02-06 18:43 ` [PATCH 4/6] scsi: remove a useless get/put_device pair in scsi_request_fn Christoph Hellwig
2014-02-12 11:38 ` Hannes Reinecke [this message]
2014-02-06 18:43 ` [PATCH 5/6] scsi: remove a useless get/put_device pair in scsi_next_command Christoph Hellwig
2014-02-12 11:39 ` Hannes Reinecke
2014-02-06 18:43 ` [PATCH 6/6] scsi: remove a useless get/put_device pair in scsi_requeue_command Christoph Hellwig
2014-02-12 11:40 ` Hannes Reinecke
2014-02-12 15:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB5D22.5070208@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).