From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Steffen Maier <maier@linux.ibm.com>
Subject: Re: [PATCH] scsi: simplify registration of scsi host sysfs attributes
Date: Mon, 15 Nov 2021 09:36:00 -0800 [thread overview]
Message-ID: <52cea40c-1de2-9742-168a-c8ff0a29f0bf@acm.org> (raw)
In-Reply-To: <20211115092922.367777-1-damien.lemoal@opensource.wdc.com>
On 11/15/21 1:29 AM, Damien Le Moal wrote:
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index 8049b00b6766..c3b6812aac5b 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -359,6 +359,7 @@ static void scsi_host_dev_release(struct device *dev)
> static struct device_type scsi_host_type = {
> .name = "scsi_host",
> .release = scsi_host_dev_release,
> + .groups = scsi_sysfs_shost_attr_groups,
> };
Many SCSI LLDs use class_to_shost() to convert a device pointer into a SCSI host
pointer. This patch makes the use of that macro very confusing since the SCSI
host class is no longer involved in attribute registration.
Thanks,
Bart.
next prev parent reply other threads:[~2021-11-16 2:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:29 [PATCH] scsi: simplify registration of scsi host sysfs attributes Damien Le Moal
2021-11-15 11:43 ` Steffen Maier
2021-11-15 17:36 ` Bart Van Assche [this message]
2021-11-16 3:29 ` Damien Le Moal
2021-11-16 4:22 ` Bart Van Assche
2021-11-16 4:54 ` Damien Le Moal
2021-11-19 8:24 ` [scsi] c8f22155c6: BUG:KASAN:slab-out-of-bounds_in_show_shost_state kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52cea40c-1de2-9742-168a-c8ff0a29f0bf@acm.org \
--to=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox