From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>,
James Bottomley <jbottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs
Date: Sun, 02 Mar 2014 09:53:53 +0100 [thread overview]
Message-ID: <5312F1A1.4070605@acm.org> (raw)
In-Reply-To: <1392287281-75002-1-git-send-email-hare@suse.de>
On 02/13/14 11:27, Hannes Reinecke wrote:
> After discussion with jejb I've dropped the EVPD parsing.
> So with this version we're just displaying the EVPD page
> 0x80 and 0x83 as hexdumps; no parsing is attempted.
> This drastically simplifies the patch, and we don't
> have to worry about any parsing errors in kernel space.
> Of course we'll need a parser in userspace, but that
> doesn't need to do any I/O. So it's still a very nice
> gain.
A general comment about this patch series: I think the cached copies of
these pages should be refreshed at least after an INQUIRY DATA HAS
CHANGED unit attention code has been received. Some SCSI target
implementations allow to change this data after a LUN has been created.
Bart.
next prev parent reply other threads:[~2014-03-02 8:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 10:27 [PATCHv7 0/3][Resend] Display EVPD pages in sysfs Hannes Reinecke
2014-02-13 10:27 ` [PATCH 1/3] scsi_sysfs: Implement 'is_visible' callback Hannes Reinecke
2014-02-13 10:28 ` [PATCH 2/3] Add EVPD page 0x83 to sysfs Hannes Reinecke
2014-03-02 8:34 ` Bart Van Assche
2014-03-05 7:56 ` Hannes Reinecke
2014-03-02 8:36 ` Bart Van Assche
2014-03-05 7:56 ` Hannes Reinecke
2014-02-13 10:28 ` [PATCH 3/3] Add EVPD page 0x80 " Hannes Reinecke
2014-02-28 7:27 ` [PATCHv7 0/3][Resend] Display EVPD pages in sysfs Hannes Reinecke
2014-03-02 8:53 ` Bart Van Assche [this message]
2014-03-05 8:00 ` Hannes Reinecke
2014-03-05 8:23 ` Bart Van Assche
2014-03-05 8:34 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5312F1A1.4070605@acm.org \
--to=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox