From: Brian King <brking@linux.vnet.ibm.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Wendy Xiong <wenxiong@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org,
Alexander Gordeev <agordeev@redhat.com>,
Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH RESEND 4/7] ipr: Get rid of superfluous call to pci_disbale_msi/msix()
Date: Wed, 19 Mar 2014 15:26:17 -0500 [thread overview]
Message-ID: <5329FD69.8060100@linux.vnet.ibm.com> (raw)
In-Reply-To: <1395258906.2185.43.camel@dabdike.int.hansenpartnership.com>
On 03/19/2014 02:55 PM, James Bottomley wrote:
> On Wed, 2014-03-12 at 16:08 -0500, wenxiong@vmlinux.vnet.ibm.com wrote:
>> From: Alexander Gordeev <agordeev@redhat.com>
>>
>> There is no need to call pci_disable_msi() or pci_disable_msix()
>> in case the call to pci_enable_msi() or pci_enable_msix() failed.
>>
>> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
>> Acked-by: Brian King <brking@linux.vnet.ibm.com>
>> ---
>
> This needs a Signed-off-by: from you as well, since you transmitted the
> patch to me. I assume it was just omitted in error and have added it in
> the git repository.
Correcting Wendy's email address...
-Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2014-03-19 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 21:08 [PATCH RESEND 0/7] New CCINs and several patches for new improvement wenxiong
2014-03-12 21:08 ` [PATCH RESEND 1/7] ipr: Remove extended delay bit on GSCSI reads/writes ops wenxiong
2014-03-14 15:50 ` Brian King
2014-03-12 21:08 ` [PATCH RESEND 2/7] ipr: Add new CCIN definition for new hardware support wenxiong
2014-03-12 21:08 ` [PATCH RESEND 3/7] ipr: Handle early EEH wenxiong
2014-03-12 21:08 ` [PATCH RESEND 4/7] ipr: Get rid of superfluous call to pci_disbale_msi/msix() wenxiong
2014-03-19 19:55 ` James Bottomley
2014-03-19 20:26 ` Brian King [this message]
2014-03-19 20:57 ` James Bottomley
2014-03-12 21:08 ` [PATCH RESEND 5/7] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() wenxiong
2014-03-12 21:08 ` [PATCH RESEND 6/7] ipr: Format HCAM overlay ID 0x21 wenxiong
2014-03-12 21:08 ` [PATCH RESEND 7/7] ipr: Add new CCIN definition for Grand Canyon support wenxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5329FD69.8060100@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agordeev@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).