From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/8] blk-mq: bidi support
Date: Wed, 16 Apr 2014 10:41:30 -0600 [thread overview]
Message-ID: <534EB2BA.7020705@kernel.dk> (raw)
In-Reply-To: <1397634299-7466-3-git-send-email-hch@lst.de>
On 04/16/2014 01:44 AM, Christoph Hellwig wrote:
> diff --git a/block/bsg.c b/block/bsg.c
> index 420a5a9..2956086 100644
> --- a/block/bsg.c
> +++ b/block/bsg.c
> @@ -1008,7 +1008,7 @@ int bsg_register_queue(struct request_queue *q, struct device *parent,
> /*
> * we need a proper transport to send commands, not a stacked device
> */
> - if (!q->request_fn)
> + if (!q->request_fn && !q->mq_ops)
> return 0;
>
> bcd = &q->bsg_dev;
This looks misplaced. But I dropped the one I generated last week, I'll
queue it up separately in the drivers branch.
--
Jens Axboe
next prev parent reply other threads:[~2014-04-16 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 7:44 next round of blk-mq updates Christoph Hellwig
2014-04-16 7:44 ` [PATCH 1/8] blk-mq: allow drivers to hook into I/O completion Christoph Hellwig
2014-04-16 7:44 ` [PATCH 2/8] blk-mq: bidi support Christoph Hellwig
2014-04-16 16:41 ` Jens Axboe [this message]
2014-04-16 16:44 ` Christoph Hellwig
2014-04-16 16:45 ` Jens Axboe
2014-04-16 16:47 ` Christoph Hellwig
2014-04-16 16:52 ` Jens Axboe
2014-04-16 7:44 ` [PATCH 3/8] blk-mq: add async paramter to blk_mq_start_stopped_hw_queues Christoph Hellwig
2014-04-16 7:44 ` [PATCH 4/8] blk-mq: add blk_mq_delay_queue Christoph Hellwig
2014-04-16 16:51 ` Jens Axboe
2014-04-16 7:44 ` [PATCH 5/8] blk-mq: add blk_mq_start_hw_queues Christoph Hellwig
2014-04-16 7:44 ` [PATCH 6/8] blk-mq: add blk_mq_requeue_request Christoph Hellwig
2014-04-16 7:44 ` [PATCH 7/8] blk-mq: rename mq_flush_work struct request member Christoph Hellwig
2014-04-16 7:44 ` [PATCH 8/8] block: export blk_finish_request Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EB2BA.7020705@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).