Re: [PATCH 01/17] block: remove a superflous ifdef in blkdev.h

Johannes Thumshirn
2022-07-04T12:58:47Z

On 04.07.22 14:45, Christoph Hellwig wrote:
> It doesn't hurt to lways have the blk_zone_cond_str prototype, and the
> two inlines can also be defined unconditionally.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> include/linux/blkdev.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index b9a94c53c6cd3..270cd0c552924 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -899,8 +899,6 @@ static inline struct request_queue *bdev_get_queue(struct block_device *bdev)
> return bdev->bd_queue; /* this is never NULL */
> }
>
> -#ifdef CONFIG_BLK_DEV_ZONED
> -
> /* Helper to convert BLK_ZONE_ZONE_XXX to its string format XXX */
> const char *blk_zone_cond_str(enum blk_zone_cond zone_cond);
>

Won't this break tracing in null_blk, which uses blk_zone_cond_str()?